[g-a-devel](no subject)

["Padraig O'Briain" <Padraig Obriain Sun COM>]

While looking at implementing atk_text_get_range_extents() I have looked at 
impl_getRangeExtents(). I believe that there are some errors in the function.

Patch attached.

OK to commit?

Padraig

? application.c.TEST
Index: text.c
===================================================================
RCS file: /cvs/gnome/at-spi/libspi/text.c,v
retrieving revision 1.18
diff -u -p -r1.18 text.c
--- text.c	18 Dec 2002 15:28:40 -0000	1.18
+++ text.c	10 Jan 2003 09:24:39 -0000
@@ -26,8 +26,10 @@
 #include <config.h>
 #include <stdio.h>
 #include <stdlib.h>
+#include <string.h>
 #include <atk/atktext.h>
 #include <libspi/text.h>
+#include <libspi/spi-private.h>
 
 /* Our parent Gtk object type */
 #define PARENT_TYPE SPI_TYPE_BASE
@@ -465,8 +467,11 @@ impl_getRangeExtents(PortableServer_Serv
 
   g_return_if_fail (text != NULL);
   
+  atk_text_get_character_extents (text, startOffset,
+			          &bounds.x, &bounds.y, &bounds.w, &bounds.h,
+				  (AtkCoordType) coordType);
   /* no equivalent ATK API yet, must do the hard way. :-( */
-  for (i = startOffset; i > endOffset; i++) 
+  for (i = startOffset + 1; i < endOffset; i++) 
     {
       atk_text_get_character_extents (text, i,
 				      &cbounds.x, &cbounds.y, &cbounds.w, &cbounds.h,