Re: [g-a-devel]Changes for at-poke



Hi Padraig,

On Wed, 2002-09-18 at 09:07, Padraig O'Briain wrote:
> I have reworked the patch.

	... you're still doing an unsafe loop destroy: ...

> +		if (is_remove) {
> +			for (l = cl->roots; l; l = l->next) {
> +				if (l->data == accessible) {
> +					g_signal_emit (cl, signals [ROOT_DIED], 0, l->data);
> +					Accessible_unref (l->data);
> +					cl->roots = g_slist_delete_link (cl->roots, l);
> +				}
> +			}

	See my spiel on the 'next' pointer being invalid, you need a 'next'
intermediate;

	Regards,

		Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]