Re: [g-a-devel]Re: ATK patch to add support for embedded text

["Padraig O'Briain" <Padraig Obriain sun com>]

Bill,

I noticed a few problems when building the docs. I had to update two files, 
atk/atkhyperlink.h and docs/atk-section.txt to fix them.

I believe that we are ready to commit now.

Padraig

> Subject: Re: [g-a-devel]Re: ATK patch to add support for embedded text
> To: "Padraig O'Briain" <Padraig Obriain sun com>
> Cc: gnome-accessibility-devel gnome org
> Mime-Version: 1.0
> 
> On Thu, 2002-11-14 at 12:44, Padraig O'Briain wrote:
> > I am going to move the definition of ATK_HYPERLINK_IS_INLINE from 
atkhyperlink.c 
> > to atkhyperlink.h.
> Thanks, that's better.  
> 
> I attach a revised patch with that change, and additions to
> docs/atk-sections.txt; also additions to tests/testrelation.c
> 
> -Bill

Index: atkhyperlink.h
===================================================================
RCS file: /cvs/gnome/atk/atk/atkhyperlink.h,v
retrieving revision 1.7
diff -u -p -r1.7 atkhyperlink.h
--- atkhyperlink.h	8 Nov 2002 18:53:55 -0000	1.7
+++ atkhyperlink.h	14 Nov 2002 14:55:41 -0000
@@ -32,6 +32,17 @@ extern "C" {
  * It implements the AtkAction interface.
  */
 
+/**
+ *AtkHyperlinkStateFlags
+ * ATK_HYPERLINK_IS_INLINE: Link is inline
+ *
+ *Describes the type of link
+ **/ 
+typedef enum 
+{
+  ATK_HYPERLINK_IS_INLINE = 1 << 0
+} AtkHyperlinkStateFlags;
+
 #define ATK_TYPE_HYPERLINK                        (atk_hyperlink_get_type ())
 #define ATK_HYPERLINK(obj)                        (G_TYPE_CHECK_INSTANCE_CAST ((obj), ATK_TYPE_HYPERLINK, AtkHyperlink))
 #define ATK_HYPERLINK_CLASS(klass)                (G_TYPE_CHECK_CLASS_CAST ((klass), ATK_TYPE_HYPERLINK, AtkHyperlinkClass))
@@ -85,10 +96,17 @@ struct _AtkHyperlinkClass
    */
   gint	           (* get_n_anchors)	   (AtkHyperlink     *link_);
 
+  /*
+   * Returns a set of bitflags which encode state information.
+   * Used by non-virtualized state query methods, not intended,
+   * for direct client use.  It is virtualized, but clients should use
+   * atk_hyperlink_is_inline (), etc.
+   */
+  guint	           (* link_state)	   (AtkHyperlink     *link_);
+  
   AtkFunction      pad1;
   AtkFunction      pad2;
   AtkFunction      pad3;
-  AtkFunction      pad4;
 };
 
 GType            atk_hyperlink_get_type             (void);
@@ -104,6 +122,8 @@ gint             atk_hyperlink_get_end_i
 gint             atk_hyperlink_get_start_index      (AtkHyperlink     *link_);
 
 gboolean         atk_hyperlink_is_valid             (AtkHyperlink     *link_);
+
+gboolean         atk_hyperlink_is_inline             (AtkHyperlink     *link_);
 
 gint		 atk_hyperlink_get_n_anchors        (AtkHyperlink     *link_);
 

Index: atk-sections.txt
===================================================================
RCS file: /cvs/gnome/atk/docs/atk-sections.txt,v
retrieving revision 1.32
diff -u -p -r1.32 atk-sections.txt
--- atk-sections.txt	30 Oct 2002 09:42:28 -0000	1.32
+++ atk-sections.txt	14 Nov 2002 14:57:45 -0000
@@ -429,11 +429,13 @@ atk_value_get_type
 <FILE>atkhyperlink</FILE>
 <TITLE>AtkHyperlink</TITLE>
 AtkHyperlink
+AtkHyperlinkStateFlags
 atk_hyperlink_get_uri
 atk_hyperlink_get_object
 atk_hyperlink_get_end_index
 atk_hyperlink_get_start_index
 atk_hyperlink_is_valid
+atk_hyperlink_is_inline
 atk_hyperlink_get_n_anchors
 <SUBSECTION Standard>
 ATK_HYPERLINK
@@ -443,6 +445,8 @@ atk_hyperlink_get_type
 ATK_HYPERLINK_CLASS
 ATK_IS_HYPERLINK_CLASS
 ATK_HYPERLINK_GET_CLASS
+atk_hyperlink_state_flags_get_type
+ATK_TYPE_HYPERLINK_STATE_FLAGS
 </SECTION>
 
 <SECTION>