Re: [g-a-devel]Re: misc. bugs ...

["Padraig O'Briain" <Padraig Obriain Sun COM>]

Michael,

I do not have a nautilus available to me at present to try this.

I am not sure I understand what ths trivial fix is. Is something on the these 
lines what you had in mind?

Padraig


Index: gailcanvasgroup.c
===================================================================
RCS file: /cvs/gnome/gail/gail/gailcanvasgroup.c,v
retrieving revision 1.8
diff -u -p -r1.8 gailcanvasgroup.c
--- gailcanvasgroup.c	20 Dec 2001 10:25:17 -0000	1.8
+++ gailcanvasgroup.c	20 Mar 2002 11:34:41 -0000
@@ -103,6 +103,7 @@ gail_canvas_group_ref_child (AtkObject *
   GnomeCanvasItem *item;
   AtkObject *accessible;
   GObject *g_obj;
+  GList *list_item;
 
   g_return_val_if_fail (GAIL_IS_CANVAS_ITEM (obj), 0);
   atk_gobject = ATK_GOBJECT_ACCESSIBLE (obj);
@@ -110,8 +111,10 @@ gail_canvas_group_ref_child (AtkObject *
   g_return_val_if_fail (GNOME_IS_CANVAS_GROUP (g_obj), 0);
   group = GNOME_CANVAS_GROUP (g_obj);
 
-  item = GNOME_CANVAS_ITEM(g_list_nth (group->item_list, i)->data);
-  g_return_val_if_fail (item, NULL);
+  list_item = g_list_nth (group->item_list, i);
+  g_return_val_if_fail (list_item, NULL);
+  g_return_val_if_fail (list_item->data, NULL);
+  item = GNOME_CANVAS_ITEM (list_item->data);
   accessible = atk_gobject_accessible_for_object (G_OBJECT (item));
   g_object_ref (accessible);
   return accessible;


> Subject: Re: [g-a-devel]Re: misc. bugs ...
> To: "Padraig O'Briain" <Padraig Obriain sun com>
> Cc: accessibility mailing list <gnome-accessibility-devel gnome org>
> Content-Transfer-Encoding: 7bit
> Mime-Version: 1.0
> 
> Hi Padraig,
> 
> On Tue, 2002-03-19 at 10:15, Padraig O'Briain wrote:
> > How do I reproduce this problem?
> 
> 	export GNOME_ACCESSIBILITY=1 ; bonobo-slay ; nautilus & ; ./at-poke
> 
> 	Then refresh and have a look at the icon container in nautilus - I
> imagine pretty much any canvas will do - that one changes the number of
> items quite regularly though which is a bonus.
> 
> 	The bug is of course trivial to fix - I assume you're just wanting to
> test the fix ?
> 
> 	Regards,
> 
> 		Michael.
> 
> > > 113	  item = GNOME_CANVAS_ITEM(g_list_nth (group->item_list, 
i)->data);
>                                                                   ^^^^
> 
> -- 
>  mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot
>