Re: [g-a-devel]Patch for SpiDesktop

[Michael Meeks <michael ximian com>]

Hi Marc,

On Fri, 2002-03-15 at 06:47, Marc Mulcahy wrote:
> The code in spi_desktop_dispose doesn't make sense to me.  This patch seems 
> in order.

	OK - so I just looked into this; there are two problems, one hidden by
a stylistic bug that really annoys me:

  while (desktop->applications)
    {
      Application *app = (Application *) desktop->applications;

	Because someone likes us to waste effort putting the £$"%£"%$£$%'ing
redundant cast in there ;o) we loose any benefit of the compiler being
able to help tell us that we're being morons and casting a GList to a
Application instead of the gpointer ->data pointer to the Application [
a void * coercion which needs no cast - clearly ].

	Secondly, the problem is that we're doing ref counting on the desktop
which is really not desirable, and this is why it's getting disposed of
- we should set the immutable bit on it.

	I'm making a patch up now + a re-enterancy bug and some stylistic
nasties that have crept in; please use macros and functions thus:

	function_name[space](arg1, arg2);

	ie. with the space ;-)

	Regards,

		Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot