[g-a-devel][PATCH} AtkObject signal inconsistencies.

[murrayc t-online de (Murray Cumming)]

While wrapping AtkObject for C++ I discovered that the signal handlers
don't match the registered signal parameter types. Here's a patch, with
my best guesses for the correct types, but you should check that I've
made the correct choices.


-- 
Murray Cumming
murrayc usa net
www.murrayc.com

? atkobject_signals.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/atk/ChangeLog,v
retrieving revision 1.160
diff -u -r1.160 ChangeLog
--- ChangeLog	2002/01/16 12:20:27	1.160
+++ ChangeLog	2002/01/27 14:09:04
@@ -1,3 +1,10 @@
+2002-01-27  Murray Cumming  <murrayc usa net>
+
+	* atk/atkobject.[h|c] Correct inconsistencies between registered signal
+	parameter types and the default signal handler struct fields for these.
+	For instance, the state_change and property_change signal handlers 
+	probably should return void.	
+
 2002-01-10  Bill Haneman <bill haneman sun com>
 
        * configure.in:
Index: atk/atkobject.c
===================================================================
RCS file: /cvs/gnome/atk/atk/atkobject.c,v
retrieving revision 1.47
diff -u -r1.47 atkobject.c
--- atk/atkobject.c	2001/12/19 12:34:24	1.47
+++ atk/atkobject.c	2002/01/27 14:09:04
@@ -297,7 +297,7 @@
 		  NULL, NULL,
 		  g_cclosure_marshal_VOID__UINT_POINTER,
 		  G_TYPE_NONE,
-		  2, G_TYPE_UINT, G_TYPE_POINTER);
+		  2, G_TYPE_UINT, ATK_TYPE_OBJECT);
   atk_object_signals[FOCUS_EVENT] =
     g_signal_new ("focus_event",
 		  G_TYPE_FROM_CLASS (klass),
Index: atk/atkobject.h
===================================================================
RCS file: /cvs/gnome/atk/atk/atkobject.h,v
retrieving revision 1.28
diff -u -r1.28 atkobject.h
--- atk/atkobject.h	2001/12/19 12:34:24	1.28
+++ atk/atkobject.h	2002/01/27 14:09:05
@@ -357,7 +357,7 @@
    * children of the object
    */
   void                    (* children_changed)    (AtkObject                  *accessible,
-                                                   gint                       change_index,
+                                                   guint                       change_index,
                                                    AtkObject                  *changed_child);
   /*
    * The signal handler which is executed  when there is a focus event
@@ -369,13 +369,13 @@
    * The signal handler which is executed  when there is a property_change 
    * signal for an object.
    */
-  gint                    (*property_change)      (AtkObject                  *accessible,
+  void                    (*property_change)      (AtkObject                  *accessible,
                                                    AtkPropertyValues          *values);
   /*
    * The signal handler which is executed  when there is a state_change 
    * signal for an object.
    */
-  gint                    (*state_change)         (AtkObject                  *accessible,
+  void                    (*state_change)         (AtkObject                  *accessible,
                                                    const gchar                *name,
                                                    gboolean                   state_set);
   /*