Re: Why is bonobo-config a 2.0 core library?

[Stephen Browne <stephen browne sun com>]

Whoops!

and here would be the patch that isnt a pile of crap.
Sorry about that.

/me suggests iain just take the dep out himself since 
it would be quicker than applying a patch :)

Thx to markmc for pointing out how much of a dufus I am.

Stephen.


On Thu, 2001-11-22 at 14:46, Stephen Browne wrote:
> Hi,
> 
> I was really hesitant to send this mail because I really dont want
> to ressurect a flamefest about bonobo-confg, but here goes anyway.
> 
> My question is in the subject and I'd like the release team to consider
> this at their next meeting.
> 
> I cant see anything in GNOME 2.0 that is (should) be using bonobo-config
> so I'm wondering why it is defined as a core 2.0 lib. If I missed
> something that is using it then let me know.
> 
> Control Center is moving to GConf now and the only other thing I could
> see that defined a dependancy on b-c was gnome-media which doesn't
> actually use it anywhere.
> 
> Also I noticed that b-c has been taken out of the list of HEAD modules
> in the vicious-build-scripts.
> 
> Iain, I have attached a patch to remove the pkg-config check for
> bonobo-config from gnome-media, mostly to follow the 'send a patch get
> get heard' process. :-)
> 
> Stephen.
> 
> 
> ----
> 

> Index: configure.in
> ===================================================================
> RCS file: /cvs/gnome/gnome-media/configure.in,v
> retrieving revision 1.111
> diff -u -r1.111 configure.in
> --- configure.in	2001/11/17 18:08:10	1.111
> +++ configure.in	2001/11/22 14:43:16
> @@ -50,7 +50,7 @@
>  # Start of pkg-config checks
>  PKG_CHECK_MODULES(MEDIA, glib-2.0 >= 1.3.7 gmodule-2.0 >= 1.3.7 \
>  		  gnome-vfs-2.0 >= 1.1 libbonobo-2.0 >= 1.100.0	\
> -		  bonobo-config-2.0 >= 0.1.3 libbonoboui-2.0 >= 1.97.0 \
> +		  0.1.3 libbonoboui-2.0 >= 1.97.0 \
>  		  libgnome-2.0 >= 1.102.0 libgnomeui-2.0 >= 1.102.0
>  		  bonobo-activation-2.0 >= 0.9.1)
>  AC_SUBST(MEDIA_CFLAGS)

Index: configure.in
===================================================================
RCS file: /cvs/gnome/gnome-media/configure.in,v
retrieving revision 1.111
diff -u -r1.111 configure.in
--- configure.in	2001/11/17 18:08:10	1.111
+++ configure.in	2001/11/22 14:57:29
@@ -50,7 +50,7 @@
 # Start of pkg-config checks
 PKG_CHECK_MODULES(MEDIA, glib-2.0 >= 1.3.7 gmodule-2.0 >= 1.3.7 \
 		  gnome-vfs-2.0 >= 1.1 libbonobo-2.0 >= 1.100.0	\
-		  bonobo-config-2.0 >= 0.1.3 libbonoboui-2.0 >= 1.97.0 \
+		  libbonoboui-2.0 >= 1.97.0 \
 		  libgnome-2.0 >= 1.102.0 libgnomeui-2.0 >= 1.102.0
 		  bonobo-activation-2.0 >= 0.9.1)
 AC_SUBST(MEDIA_CFLAGS)