Re: Patch has been committed, but there are outstanding files including files they shouldn't.

Miles Lane <miles megapathdsl net> writes:

> With the changes I've already committed, I can now build all the
> modules in ~/bin/head/ again.
> The following are suspect.  If you'd like me to generate a patch 
> to convert these to including glib-object.h instead, let me know
> and I'll be happy to do so.

Yes, these all need to be fixed as well. (Especially the
gnometypebuiltins.h use)

Because these didn't show cause errors, they are actually all useless
includes and probably should just be removed, though that is somewhat
up to the taste of the module maintainer. For gdk-pixbuf-loader.c, I
just removed the include there.

I guess we need to move the invalid include checks _outside_ the
repeated include guards to catch cases like this ... but I'll give you
some time to fix these before I do that.

> ./libbonoboui/bonobo/bonobo-ui-marshal-main.c:3:#include <gobject/genums.h>
> ./libgnomeui/libgnomeui/gnometypebuiltins.h:7:#include <gobject/genums.h>
> ./gnome-core/panel/panel-marshal-main.c:1:#include <gobject/genums.h>
> ./gnome-core/panel/panel-typebuiltins.c:4:#include <gobject/genums.h>
> ./gconf/gconf/gconf-client.c:25:#include <gobject/gobject.h>
> ./libbonoboui/bonobo/bonobo-ui-xml.h:13:#include <gobject/gobject.h>
> ./libbonoboui/samples/compound-doc/container/component.h:5:#include <gobject/gobject.h>
> ./libbonoboui/samples/compound-doc/container/document.h:4:#include <gobject/gobject.h>
> ./libgtop/include/glibtop/glibtop-backend.h:30:#include <gobject/gobject.h>
> ./libgtop/include/glibtop/glibtop-client.h:30:#include <gobject/gobject.h>
> ./eel/eel/eel-gobject-extensions.h:30:#include <gobject/gobject.h>
> ./nautilus/libnautilus/nautilus-undo-private.h:29:#include <gobject/gobject.h>
> ./gtk+/gdk-pixbuf/gdk-pixbuf-loader.c:33:#include <gobject/gsignal.h>
> ./gconf/gconf/gconf-client.c:26:#include <gobject/gsignal.h>
> ./libbonoboui/bonobo/bonobo-ui-engine.c:15:#include <gobject/gsignal.h>
> ./libbonoboui/bonobo/bonobo-ui-xml.c:12:#include <gobject/gsignal.h>
> ./libgnomeui/libgnomeui/libgnomeuiP.h:31:#include <gobject/gsignal.h>
> ./libgtop/lib/glibtop-backend.c:28:#include <gobject/gsignal.h>
> ./libgtop/lib/glibtop-client.c:28:#include <gobject/gsignal.h>
> ./nautilus/components/sample/nautilus-sample-content-view.c:39:#include <gobject/gsignal.h>

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]