GNOME.org
 

Re: libgnomeui patch

Maciej Stachowiak wrote:


On 03Nov2001 09:54PM (+0100), Rodrigo Moya wrote:


On Sat, 2001-11-03 at 21:53, Anders Carlsson wrote:


On Sat, 2001-11-03 at 21:40, Rodrigo Moya wrote:


Hi!

Here's a simple patch that adds gnome-vfs-module-2.0 to the list of
libraries for libgnomeui, which was needed to compile it on my system.

May I commit?


Hi,

I think this patch is wrong. gnome-vfs-module isn't used by anything in
libgnomeui. What's the compile error you get? Perhaps the error is in
the .pc file of libgnome? 
there was an error when including libgnomevfs headers, which in turn
include some of the headers in $includedir/gnome-vfs-module-2.0.

I think you're right that the patch is not correct, maybe it should be
gnome-vfs who adds all the needed -I flags?



Code that is not a gnome-vfs module should not be including headers
from $includedir/gnome-vfs-module-2.0. I'll check it out and remove
the inappropriate includes if possible.
I think I'm seeing something similar in libgnome. help-method.c is having all kinds of header file problems. Here's the error I'm seeing, using rebuild.sh on gnome-head.
gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I/gnome/head/INSTALL/include/glib-2.0 -I/gnome/head/INSTALL/lib/glib-2.0/include -I/gnome/head/INSTALL/include/gnome-vfs-2.0 -I/gnome/head/INSTALL/lib/gnome-vfs-2.0/include -I/gnome/head/INSTALL/include/bonobo-activation-2.0 -I/gnome/head/INSTALL/include/orbit-2.0 -I/gnome/head/INSTALL/include/linc-1.0 -I/gnome/head/INSTALL/include/libxml2 -I/gnome/head/INSTALL/include/gnome-vfs-module-2.0 -I/gnome/head/INSTALL/include/libbonobo-2.0 -I/gnome/head/INSTALL/include/gconf/2 -I/gnome/head/INSTALL/include -g -O2 -Wp,-MD,.deps/help-method.pp -c help-method.c -fPIC -DPIC -o .libs/help-method.lo In file included from /gnome/head/INSTALL/include/gnome-vfs-2.0/libgnomevfs/gnome-vfs-handle.h:27, from /gnome/head/INSTALL/include/gnome-vfs-2.0/libgnomevfs/gnome-vfs-async-ops.h:32, from /gnome/head/INSTALL/include/gnome-vfs-2.0/libgnomevfs/gnome-vfs.h:28, 
                from help-method.h:4,
                from help-method.c:24:
/gnome/head/INSTALL/include/gnome-vfs-2.0/libgnomevfs/gnome-vfs-method.h:29:43: libgnomevfs/gnome-vfs-context.h: No such file or directory In file included from /gnome/head/INSTALL/include/gnome-vfs-2.0/libgnomevfs/gnome-vfs-handle.h:27, from /gnome/head/INSTALL/include/gnome-vfs-2.0/libgnomevfs/gnome-vfs-async-ops.h:32, from /gnome/head/INSTALL/include/gnome-vfs-2.0/libgnomevfs/gnome-vfs.h:28, 
                from help-method.h:4,
                from help-method.c:24:
/gnome/head/INSTALL/include/gnome-vfs-2.0/libgnomevfs/gnome-vfs-method.h:32:45: libgnomevfs/gnome-vfs-transform.h: No such file or directory 
In file included from help-method.h:4,
                from help-method.c:24:
/gnome/head/INSTALL/include/gnome-vfs-2.0/libgnomevfs/gnome-vfs.h:33:51: libgnomevfs/gnome-vfs-module-callback.h: No such file or directory 
In file included from help-method.h:4,
                from help-method.c:24:
/gnome/head/INSTALL/include/gnome-vfs-2.0/libgnomevfs/gnome-vfs.h:37:45: libgnomevfs/gnome-vfs-transform.h: No such file or directory 
help-method.c:30:40: libgnomevfs/gnome-vfs-mime.h: No such file or directory
help-method.c:31:49: libgnomevfs/gnome-vfs-module-shared.h: No such file or directory help-method.c:32:42: libgnomevfs/gnome-vfs-module.h: No such file or directory 
make[3]: *** [help-method.lo] Error 1
make[3]: Leaving directory `/gnome/head/cvs/libgnome/help-converters/gnome-vfs-module' 
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/gnome/head/cvs/libgnome/help-converters'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/gnome/head/cvs/libgnome'
make: *** [all-recursive-am] Error 2




- Maciej

_______________________________________________
gnome-2-0-list mailing list
gnome-2-0-list gnome org
http://mail.gnome.org/mailman/listinfo/gnome-2-0-list
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]