Re: libgnomeui patch

[Maciej Stachowiak <mjs noisehavoc org>]

On 03Nov2001 09:54PM (+0100), Rodrigo Moya wrote:
> On Sat, 2001-11-03 at 21:53, Anders Carlsson wrote:
> > On Sat, 2001-11-03 at 21:40, Rodrigo Moya wrote:
> > > Hi!
> > > 
> > > Here's a simple patch that adds gnome-vfs-module-2.0 to the list of
> > > libraries for libgnomeui, which was needed to compile it on my system.
> > > 
> > > May I commit?
> > > 
> > 
> > Hi,
> > 
> > I think this patch is wrong. gnome-vfs-module isn't used by anything in
> > libgnomeui. What's the compile error you get? Perhaps the error is in
> > the .pc file of libgnome? 
> > 
> there was an error when including libgnomevfs headers, which in turn
> include some of the headers in $includedir/gnome-vfs-module-2.0.
> 
> I think you're right that the patch is not correct, maybe it should be
> gnome-vfs who adds all the needed -I flags?

Code that is not a gnome-vfs module should not be including headers
from $includedir/gnome-vfs-module-2.0. I'll check it out and remove
the inappropriate includes if possible.

 - Maciej