Re: GNOME CVS: libglade jamesh

[jacob berkman <jacob ximian com>]

On Fri, 2 Nov 2001, James Henstridge wrote:

> jacob berkman wrote:
>
> >On Thu, 2001-11-01 at 18:06, James Henstridge wrote:
> >
> >>jacob berkman wrote:
> >>
> >>>On Tue, 2001-10-30 at 23:10, Gnome CVS User wrote:
> >>>
> >>>>* doc/Makefile.am: remove update-libglade crack, as it breaks the
> >>>>distcheck.
> >>>>
> >
> >>>how does it break distcheck?  is it only on automake 1.5?  it works fine
> >>>for me with the update-libglade "crack" with automake 1.4p5.
> >>>
> >>You added update-libglade to the EXTRA_DIST variable, which is a non
> >>existant file (nor any rules to build it, or reasons to include it in
> >>the tarball).  When doing a make distcheck, it tried to copy the file to
> >>the distdir, but failed, which caused the failure.
> >>
> >
> >oh - i guess i forgot to add it to .PHONY.  does the attached patch
> >work?
> >
> Don't see any patch, but having it listed in EXTRA_DIST is what breaks
> things, as there is no file to distribute.

oops, should be there now.

>
> >
> >>Is there any reason not to simply run "make" before "make dist"?
> >>
> >
> >because this is immensly broken?  is there a legit reason /to/ run make
> >before make dist?
> >
> And the fact that so many modules couldn't build without an initial
> "make" doesn't count as a valid reason?

it's only because of gtk-doc or automake being stupid, and is easily
fixable.


jacob
-- 
In the afterlife, a cute .signature will only get you so far.

Index: Makefile.am
===================================================================
RCS file: /cvs/gnome/libglade/doc/Makefile.am,v
retrieving revision 1.20
diff -u -r1.20 Makefile.am
--- Makefile.am	2001/10/31 04:10:03	1.20
+++ Makefile.am	2001/11/02 01:28:58
@@ -34,9 +34,13 @@
 	libglade-decl.txt		\
 	libglade-sections.txt		\
 	libglade-docs.sgml		\
-	libglade.types
+	libglade.types			\
+	update-libglade
 
-scan-build.stamp: $(top_srcdir)/glade/*.h
+update-libglade:
+	$(MAKE) $(AM_MAKEFLAGS) -C $(top_builddir)/glade
+
+scan-build.stamp: $(top_srcdir)/glade/*.h update-libglade
 	@echo '*** Scanning header files ***'
 	@-chmod -R u+w $(srcdir)
 	env CC="$(LIBTOOL) --mode=compile $(CC)" \
@@ -109,4 +113,4 @@
 	-cp $(srcdir)/tmpl/*.sgml $(DESTDIR)$(distdir)/tmpl
 	-cp $(srcdir)/sgml/*.sgml $(DESTDIR)$(distdir)/sgml
 
-.PHONY : html sgml templates scan
+.PHONY : html sgml templates scan update-libglade