Re: [gnet-dev] GNet 2 for Windows?

[Hans Petter Jansson <hpj ximian com>]

On Tue, 2003-06-03 at 19:55, Andrewlanoix aol com wrote:

> I do not know how to make a glib release that will be equivalent to 
> the one that you can download from Tor’s website. I ran into some 
> issues compiling with VC so I built all the dlls in one dll and 
> commented any unnecessary code that would not link to debug the 
> iochannel code. I can give you this dll, you can build glib yourself, 
> someone else could volunteer to build glib or someone can ask Tor to 
> build glib.

I think the patches should at least be sent to Tor. He will review them
and merge the functionality into GLib CVS, from which we'll get
releases.

I have a couple of GNet/win32 nitpicks that you've probably already
fixed. The first is a pointer indirection problem, and the others are
places where the win32 code's behaviour differs from the unix one - it
calls the callback function even if the operation fails immediately and
it returns NULL. Diffs below, just in case.

---

diff -rwup gnet-2.0.3/src/inetaddr.c gnet-2.0.3-modified/src/inetaddr.c
--- gnet-2.0.3/src/inetaddr.c   Tue May 13 20:16:46 2003
+++ gnet-2.0.3-modified/src/inetaddr.c  Thu May 29 20:47:26 2003
@@ -1371,7 +1373,7 @@ gnet_inetaddr_new_list_async_cb (GIOChan
 {
 
   GInetAddrNewListState* state = (GInetAddrNewListState*) data;
-  GInetAddr* ia = (GInetAddr*) &state->ias->data;
+  GInetAddr* ia = (GInetAddr*) state->ias->data;
   struct hostent *result;
   struct sockaddr_in *sa_in;
 
diff -rwup gnet-2.0.3/src/tcp.c gnet-2.0.3-modified/src/tcp.c
--- gnet-2.0.3/src/tcp.c        Tue May 13 20:16:46 2003
+++ gnet-2.0.3-modified/src/tcp.c       Thu May 29 20:47:32 2003
@@ -542,7 +542,7 @@ gnet_tcp_socket_new_async_direct (const 
   sockfd = socket(GNET_INETADDR_FAMILY(addr), SOCK_STREAM, 0);
   if (sockfd == INVALID_SOCKET)
     {
-      (func)(NULL, data);
       return NULL;
     }
        
@@ -586,7 +586,7 @@ gnet_tcp_socket_new_async_direct (const 
 
   if (state->connect_watch <= 0)
     {
-      (func)(NULL, data);
       return NULL;
     }
 
-- 
Hans Petter