[gmime-devel] [PATCH] Rename g_mime_decryption_result_* to g_mime_decrypt_result_*
- From: Daniel Kahn Gillmor <dkg fifthhorseman net>
- To: Gmime Development <gmime-devel-list gnome org>
- Subject: [gmime-devel] [PATCH] Rename g_mime_decryption_result_* to g_mime_decrypt_result_*
- Date: Tue, 17 Jan 2017 07:58:38 -0500
Two functions appear to have been misnamed in gmime-crypto-context.c:
g_mime_decryption_result_get_mdc and
g_mime_decryption_result_get_session_key. They should have been named
with a prefix of g_mime_decrypt_, not g_mime_decryption_ :(
Correcting this is technically an ABI change, but i don't think it
matters: the wrong function names never ended up in any .h files, so i
don't think anyone could have reliably used them. A search of all of
debian shows no uses outside of the declaration in gmime itself:
https://codesearch.debian.net/search?q=g_mime_decryption_result
If you'd rather see a patch that retains the old/misnamed functions as
an alias to the correctly-named functions to technically keep the ABI
intact, i can supply that instead.
---
gmime/gmime-crypto-context.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gmime/gmime-crypto-context.c b/gmime/gmime-crypto-context.c
index 2ae77c61..5ed2edba 100644
--- a/gmime/gmime-crypto-context.c
+++ b/gmime/gmime-crypto-context.c
@@ -893,7 +893,7 @@ g_mime_decrypt_result_set_mdc (GMimeDecryptResult *result, GMimeDigestAlgo mdc)
* Returns: the mdc digest algorithm used.
**/
GMimeDigestAlgo
-g_mime_decryption_result_get_mdc (GMimeDecryptResult *result)
+g_mime_decrypt_result_get_mdc (GMimeDecryptResult *result)
{
g_return_val_if_fail (GMIME_IS_DECRYPT_RESULT (result), GMIME_DIGEST_ALGO_DEFAULT);
@@ -935,7 +935,7 @@ g_mime_decrypt_result_set_session_key (GMimeDecryptResult *result, const char *s
* session key was requested or found.
**/
const char *
-g_mime_decryption_result_get_session_key (GMimeDecryptResult *result)
+g_mime_decrypt_result_get_session_key (GMimeDecryptResult *result)
{
g_return_val_if_fail (GMIME_IS_DECRYPT_RESULT (result), NULL);
--
2.11.0
[Date Prev][
Date Next] [Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]