Re: [gmime-devel] header line endings

[Kane Kim <kane isturm gmail com>]

Nevermind, found it in your personal repo: https://github.com/jstedfast/gmime

On Thu, Aug 17, 2017 at 8:57 AM, Kane Kim <kane isturm gmail com> wrote:

Can you point me to a commit please? I'm checking here: https://git.gnome.org/browse/gmime/log/, but it seems it's outdated.

Thanks.

On Thu, Aug 17, 2017 at 8:54 AM, Kane Kim <kane isturm gmail com> wrote:

This is amazing, checking the fix.

Thanks a ton!

On Thu, Aug 17, 2017 at 8:51 AM, Jeffrey Stedfast <jestedfa microsoft com> wrote:

I’ve already fixed it in git master already

 

Jeff

 

From: Kane Kim <kane isturm gmail com>
Date: Thursday, August 17, 2017 at 11:48 AM
To: Jeffrey Stedfast <jestedfa microsoft com>
Cc: "gmime-devel-list gnome org" <gmime-devel-list gnome org>
Subject: Re: [gmime-devel] header line endings

 

If it seems like a bug, I've submitted one: https://bugzilla.gnome.org/show_bug.cgi?id=786430

 

On Thu, Aug 17, 2017 at 8:40 AM, Kane Kim <kane isturm gmail com> wrote:

If you point me to where it should happen - I can try to come up with the patch as well. 

I also found it confusing that some headers explicitly append newline based on preferences: 

g_mime_header_format_message_id

g_mime_header_format_references

g_mime_header_format_received etc

 

and others don't. 

Can you explain at which point newlines appended to a header?

I see something around these lines:

https://github.com/GNOME/gmime/blob/b80cb3455b968067eb979f4d6260e57dabe90626/gmime/gmime-header.c#L424

does header->raw_value contain newline already?

 

As far as I can track it, g_mime_stream_write_string doesn't append anything to data it writes.

 

 

On Thu, Aug 17, 2017 at 8:18 AM, Jeffrey Stedfast <jestedfa microsoft com> wrote:

Hey Kane,

 

Sorry I didn’t reply yesterday. Got sidetracked at work and forgot about it.

 

This looks like a bug and I’ll see if I can fix it in git master soon.

 

Thanks!

 

Jeff

 

From: gmime-devel-list <gmime-devel-list-bounces@gnome.org> on behalf of Kane Kim <kane isturm gmail com>
Date: Tuesday, August 15, 2017 at 8:06 PM
To: "gmime-devel-list gnome org" <gmime-devel-list gnome org>
Subject: [gmime-devel] header line endings

 

I'm trying to use g_mime_format_options_set_newline_format to control line endings when writing message to a stream, it seems that it doesn't affect header line endings though. They are always written as \n. 

 

Is it possible to control which line ending gets written in headers?