On Mon 2016-12-05 10:21:40 -0500, Jeffrey Stedfast wrote:
Just committed these 6 patches, thanks!
hey, thanks!
I kept the secret_fd name, though, as I'm not a fan of the multipurpose_fd name. 2 out of the 3 uses are secret, anyway :) meh!
works for me ;)
I did add the extended comment documenting secret_fd, though. I can definitely see how that is useful for understanding the code.
yeah, i ended up writing it so that i could make sense of what was going
on, and then i figured i'd leave it in there for whoever comes and looks
under the hood in the future.
Any chance we can get a release of gmime with this functionality?
One outstanding question for you to consider: would you rather keep the
current {set,get}_retrieve_session_key interface as part of
GMimeGpgContext, or would you prefer to have it as part of the generic
GMimeCryptoContext interface?
I don't think we have any other backend that could support it at the
moment, but it seems concievable that another backend could be written
in the future, either for S/MIME (CMS) or a non-GnuPG OpenPGP
implementation that would want to support that flag.
implementations that don't support it would just return an error when
trying to set(TRUE).
If you'd prefer that the flag is be exposed on the CryptoContext, i can
send you a short patch that makes that transition.
what do you think?
--dkg
Attachment:
signature.asc
Description: PGP signature