Re: [gmime-devel] Issue with header decoding (continues)

[Jeffrey Stedfast <fejj gnome org>]

Hi,

This patch will only work in cases where the encoded-words are tagged as UTF-8, but won't work in any other case.

The real workaround for these broken headers is a bit more involved.

I'll try to look into writing up a real fix for this soon. I've got a few ideas on how I'd like to do this, but I need to flush out the details.

Jeff

On 12/18/2011 09:02 AM, evil legacy wrote:

Hi, 

Came across another header decoding problem when dealing with badly split utf-8 headers, i.e:

=?utf-8?B?16nXoteV158g15PXldek16cgR0FSTUlOINei150gR1BTINee15XXkdeg15Qg15XXktc=?=  =?utf-8?B?nSDXkNeo16DXpyDXkNeV16TXoNeq15kg157XoteV16gg157XqdeV15HXlyE=?='

it looks like someone splited an utf-8 string wrongly, leaving "half" a char on each part

g_mime_utils_header_decode_text/phrase split the header into words and decode each word separately, and since it's utf8, iconv isn't used and the string validates with this loop:

while (!g_utf8_validate (p, len, (const char **) &p)) {

len = declen - (p - (char *) decoded);

*p = '?';

}

because the original string is poorly (brokenly) splited, the 'half' chars are replaced with '?'

I'm attaching a patch that moves the utf-8 validation to the end of g_mime_utils_header_decode_text/phrase, where these decoded words are already combined

Best Regards

On Sat, Dec 17, 2011 at 6:49 PM, Jeffrey Stedfast <fejj gnome org> wrote:

Hi,

I've just released GMime 2.4.29 and 2.6.2 with your fix (and other similar fixes).

Jeff

On 12/14/2011 01:26 PM, evil legacy wrote:

Hi, 

After more debugging, I found that the problem is when iconv (cd, NULL, NULL, &outbuf, &outleft) tries to flush the buffer to outbuf, but outbuf isn't big enough to hold it.

This little patch to the charset_convert function seems to fix this problem (works for me):

<patch>

diff --git a/gmime/gmime-utils.c b/gmime/gmime-utils.c

index ca32b61..093deee 100644

--- a/gmime/gmime-utils.c

+++ b/gmime/gmime-utils.c

@@ -1553,7 +1553,15 @@ charset_convert (iconv_t cd, const char *inbuf, size_t inleft, char **outp, size

                }

        } while (inleft > 0);

        

-       iconv (cd, NULL, NULL, &outbuf, &outleft);

+       while (iconv (cd, NULL, NULL, &outbuf, &outleft) == (size_t) -1)

+               if (errno == E2BIG) {

+                       outlen += 16;

+                       rc = (size_t) (outbuf - out);

+                       out = g_realloc (out, outlen + 1);

+                       outleft = outlen - rc;

+                       outbuf = out + rc;

+               }

+

        *outbuf++ = '\0';

        

        *outlenp = outlen;

</patch>

Best Regards

_______________________________________________
gmime-devel-list mailing list
gmime-devel-list gnome org
http://mail.gnome.org/mailman/listinfo/gmime-devel-list

--
map{map{$a=unpack"C",$_;map{$c=$a-ord;print$_ x$c and goto"a"if$c>0}("Z",
" ");a:}split//;print"\n"}(q{&[%[%`#[%["},q{&[$[![$[%["[%["},q{&[#[#[#[%[
"[%["},q{&["[%["`#a"},q{[%["a"[([%["},q{[%["[%["[([%["},q{!_#[%["[([%["})