[Glade-devel] [PATCH] Implement preview feature in glade-3



Hi!

The patch seems to require a dependency on libglade. We don't want to
use libglade in glade3 for various reasons. This library has also just
been deprecated in favour of the new GtkBuilder API in GTK 2.10.

How about changing your implementation to use GtkBuilder instead? When
you are done with that, please post your patch on Bugzilla [1]. That's
where we organise and discuss new patches. 

Note, right now glade3 cannot save in the GtkBuilder format, so your
patch will have to temporarily work around that for the time being. The
GTK tool 'gtk-builder-convert' is able to do a conversion from the
libglade format into the new one.

Some comments on the patch:

* There should be a menu item corresponding to the item in the
  toolbar. It would best to put it under the "View" menu.

* Please use a more helpful error message such as:
  "Cannot create preview: unable to save temporary file"

* we need that icon "preview.png" included alongside your patch.
  Store it in the data/icons directory in the glade3 package. Remember
  to edit data/icons/Makefile.am so that the icon will be installed
  along with the others.

Good work so far. Thanks for your interest in Glade!

Vincent

1. <http://bugzilla.gnome.org/enter_bug.cgi?product=glade3>






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]