Re: [Gimp-developer] Enhanced smudge tool : Smudge with painting
- From: <b91502038 ntu edu tw>
- To: "Michael Natterer" <mitch gimp org>
- Cc: <gimp-developer-list gnome org>
- Subject: Re: [Gimp-developer] Enhanced smudge tool : Smudge with painting
- Date: Fri, 28 Apr 2017 01:22:23 +0800
Sorry that recently I have no much spare time to work at it. I know this
tool still needs some improvements before it can be officially released.
----------
From: Michael Natterer
Sent: Saturday, April 22, 2017 9:55 AM
To: b91502038 ntu edu tw ; gimp-developer-list gnome org
Subject: Re: [Gimp-developer] Enhanced smudge tool : Smudge with painting
- gimp_gegl_smudge_blend() and its parameters were renamed
for (imo) no good reason
- variables should be declared at the start of a block
- we don't use c++ comments
About the first one, gimp_gegl_smudge_with_paint() is not a renaming, but a
new function with different algorithm. The old one,
gimp_gegl_smudge_blend(), was removed since only smudge tool used it.
I used the same variable name with gimp_smudge_motion() for easier to read.
And the other two, I have changed yet. I would try to implement color from
gradient and color brush later, and update both changes together.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]