Re: [Gegl-developer] [PATCH 1/1] video-degradation: Don't crash when CL build fails

[pippin gimp org]

On Sun, May 15, 2016 at 04:03:22PM -0400, Jan Vesely wrote:
> On Sun, 2016-05-15 at 14:12 +0200, Øyvind Kolås wrote:
> > Please use bugzilla which is GEGLs normal patch/bug handling system.
> > I've pushed these changes to git master - albeit with slightly
> > deteriorated meta data since the diffs were manually incorporated.
>
> thank you, I'll use bugzilla next time. I assumed everybody just uses
> git am.

We do use git am formatted patches - but attached to bugs in bugzilla instead
of sent to the mailinglist - they might linger for a while, but at least not be
forgotten like messages to the mailinglist more readily might be. I have
workflows for picking patches from bugzilla attachements, but no sensible way
to get your contribution without more manual intervention out of the mail
(clients).

> The unexpected part is that the test now passes, despite not doing any
> processing. I have attached diff between reference and OpenCL result.
> note that CPU version of the algorithm produces the exact same picture
> as OpenCL (which did no processing)

Odd,. both http://gegl.org/operations.html#gegl%3Avideo-degradation and
https://git.gnome.org/browse/gegl/plain/tests/compositions/reference/video-degradation.png
seem to have processing happening to me.

/pippin