Re: [Gegl-developer] GEGL OpenCL Porting

[Victor Oliveira <victormatheus gmail com>]

Hi Nanley,

I'd recommend you follow operations/common/brightness-contrast.c file
for a point-filter operation (i.e. a pixel-wise filter) instead of
doing what you did.

Notice that in operations/common/brightness-contrast.c#n153 there's a
string brightness_contrast_cl_source which is a string in
opencl/brightness-contrast.cl.h, these are auto-generated files from
the kernels in the opencl folder.

Let me know what happens from that.

Victor

On Tue, Nov 18, 2014 at 4:45 PM, Nanley Chery <nanleychery gmail com> wrote:
> Hi Victor,
>
> Thank you very much for taking a look. I understand about the time.
>
> Here's the link to my bitbucket branch:
> https://bitbucket.org/nanoman281/gegl-cse6230/branch/vid_upstrm
>
> The latest commit is what's causing the video-degradation.xml test to fail
> (I'm testing using run-compositions.py).
>
> Nanley
>
> On Tue, Nov 18, 2014 at 5:11 PM, Victor Oliveira <victormatheus gmail com>
> wrote:
> > Hi Nanley,
> >
> > Just to let you know, I'll need some time to answer that because I'll
> > need to build GIMP on my new laptop.
> >
> > Can you share your code so I can give a look?
> >
> > Victor
> >
> > On Tue, Nov 18, 2014 at 12:49 PM, Nanley Chery <nanleychery gmail com>
> > wrote:
> > > Hi Victor,
> > >
> > > I'm a student working on OpenCL porting work for my High Performance
> > > Computing class. I'm trying to implement an OpenCL port for the
> > > newly-committed video-degradation operation. Are you willing to provide
> > > guidance on the following roadblock?
> > >
> > >
> > > The issue that I'm finding is that creating a cl_process method and
> > > setting
> > > the following variables in gegl_op_class_init is not enough to get the
> > > cl_process method called:
> > >
> > > operation_class->opencl_support = TRUE;
> > > point_filter_class->cl_process = cl_process;
> > >
> > > If I manually try to call the cl_process function in the process method
> > > (like in edge-laplace.c), the program terminates in the
> > > gegl_cl_set_kernel_args method without an error from CL_CHECK;
> > >
> > > Is there something I'm missing? I apologize for mailing you directly
> > > instead
> > > of writing to the mailing list. I'm a little pressed for time, so I
> > > opted
> > > for this option.
> > >
> > > Regards,
> > > Nanley