Re: [gedit-list] [PATCH] Ctrl-Tab/Ctrl-Shift-Tab to move between tabs

[Paolo Borelli <pborelli katamail com>]

Il giorno ven, 23/12/2005 alle 11.13 -0800, dave ha scritto:
> Hello,
> 
> Attached is a patch that enables switching between tabs with 
> Ctrl-Tab/Ctrl-Shift-Tab for backwards and forwards, respectively.  This 
> is my first gedit patch, so I'm treading a bit cautiously.  There don't 
> seem to be any issues, except that something doesn't feel right about 
> have to handle the accelerator in gedit-window::key_press-event, and I'm 
> sure accessibility is broken since I've stolen tab-to-focus~ ability.
> 
> Comments are most welcome.
> 

Hello Dave,

	nice to see you jump in with a patch :)

>From a code point of view the patch seems ok to me (I just gave a quick
look though).
However as yourself noted, the patch conflicts with the accessibility
use of Tab, which is something we cannot afford.
I am also not really convinced by the additional menu items: switching
to the next tab can be accomplished by simply clicking the tab or by
using shortcuts (ctrl+alt+pgUp/pgDown), why would one want to use a menu
item? We try to keep menu items to a minimum to not clutter the UI...

Keep on hacking though, it's lots of fun :)


ciao
	Paolo