Re: [Geary] Prefetch period not working for INBOX

[Michael Gratton <mike vee net>]

Hey Ricardo,

Thanks for looking into this.

On Tue, Dec 13, 2016 at 10:23 AM, Ricardo Bugalho <rbugalho gmail com> 
wrote:
> from my testing, the prefetch_period_days does not work for INBOX.
> This is annoying, I want to prefetch all my e-mail, so I can run 
> search
> es.
>
> As far as I could, I've traced the problem down to this condition in
> send_all:
>
>     if (imap_folder.get_open_state() != Folder.OpenState.CLOSED)
>                 continue;
>
> https://github.com/GNOME/geary/blob/master/src/engine/imap-engine/imap-
> engine-account-synchronizer.vala#L151
>
> INBOX is always open and thus is never sent to process_queue_async.
>
> I've tried removing that condition and it _seems_ to work OK.
> From the comment in that block, it's not clear whether that condition
> is just a performance optimization or it there's a possible 
> consistency
> issue lurking.

Your diagnosis sounds pretty much spot on, but rather than simply 
removing that check (it is actually quite useful) we want to instead 
not skip open folders if they were just made available - i.e. Geary 
just discovered them after connecting, etc.

I have just filed Bug 776029 
<https://bugzilla.gnome.org/show_bug.cgi?id=776029> and attached a 
patch that does just that. Can you test that out and let me know if it 
also resolves the issue for you?

Thanks!
//Mike

--
⊨ Michael Gratton, Percept Wrangler.
⚙ <http://mjog.vee.net/>