Re: [gdm-list] Patches for multi-seat and multi-display support

[Dan Nicholson <dbn lists gmail com>]

On Mon, May 11, 2009 at 12:23 PM, Ray Strode <halfline gmail com> wrote:
> Hi,
>
> On Thu, Apr 9, 2009 at 7:02 AM, Halton Huo <Halton Huo sun com> wrote:
>> Hi,
>>
>> Here comes the patches for multi-seat and multi-display support, please
>> review:
>>
>> * https://bugs.freedesktop.org/attachment.cgi?id=24683
>>  ConsoleKit part based on ConsoleKit-0.3.0 tarball release
>
> I've checked you're ConsoleKit patch onto the 'multi-seat' branch in
> ConsoleKit git while we work on it:
>
> http://cgit.freedesktop.org/ConsoleKit/log/?h=multi-seat
>
> and your gdm patch onto the 'display-configuration' branch in gdm git:
>
> http://git.gnome.org/cgit/gdm/log/?h=display-configuration
>
> Here's a review of the ConsoleKit bits, I'll hold off on the GDM
> review until we've discussed the ConsoleKit
> changes a bit (since changes to ConsoleKit will imply changes to GDM).
>
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -175,6 +175,7 @@ dnl ---------------------------------------------------------------------------
>>
>>  CK_BACKEND=""
>>  KVM_LIBS=""
>> +X11_DIR="/usr/bin"
>>  case "$host" in
>>          *-*-freebsd*)
>>          CK_BACKEND="freebsd"
>> @@ -189,11 +190,13 @@ case "$host" in
>>          ;;
>>          *-*-solaris*)
>>          CK_BACKEND="solaris"
>> +        X11_DIR="/usr/X11/bin"
>>          ;;
>>       *)
>>       AC_MSG_ERROR([No sysdeps back-end implemented for host $host])
>>       ;;
>>  esac
>> +AC_SUBST(X11_DIR)
>>
>>  AC_SUBST(KVM_LIBS)
>
> Can you figure out X11_DIR from pkg-config?

That would only work for Xorg, but you could do something like this:

X11_DIR=`$PKG_CONFIG --variable=bindir xorg-server 2>/dev/null`
if test "x$X11_DIR" = x; then
    AC_PATH_PROGS([XSERVER], [Xorg X],,[$PATH:/usr/X11/bin:/usr/bin])
    test "x$XSERVER" != x && X11_DIR=`dirname "$XSERVER"`
fi
test "x$X11_DIR" = x && X11_DIR=$bindir
AC_SUBST([X11_DIR])

But, wouldn't it be better to just get the name of the server itself
and let the user specify it if they want?

AC_ARG_WITH([xserver],
    [AS_HELP_STRING([--with-xserver=X], [specify X server to use])],
    [XSERVER=$withval])
if test "x$XSERVER" = x; then
    AC_PATH_PROGS([XSERVER], [Xorg X], [/usr/bin/X],
[$PATH:/usr/X11/bin:/usr/bin])
    test "x$XSERVER" = x && AC_MSG_ERROR([no X server found])
fi
AC_SUBST([XSERVER])

I'd imagine any distro/vendor would specify what they want, and anyone
doing fancy things like multiseat will be editing the configuration
files anyway.

--
Dan