Re: [gdm-list] Bringing back a11y

[Brian Cameron <Brian Cameron Sun COM>]

Ray:

I'm seeing a problem in the GDM audit code for Solaris.  I had to make
the attached patch in order to prevent GDM from exiting on assert and
never starting the login screen.  Note I added a simple call to
return to avoid it failing on the g_return_if_fail line just below.

I thought we were pretty sure that username should never be NULL by
the time the report_login function is called.

I notice that the Linux code does not have a similar check to
ensure that the username is not NULL.  I wonder if you add such
a test if you would also start seeing failure?

Thoughts?

Brian

Index: gdm-session-solaris-auditor.c
===================================================================
--- gdm-session-solaris-auditor.c	(revision 5740)
+++ gdm-session-solaris-auditor.c	(working copy)
@@ -96,6 +96,9 @@
 
        solaris_auditor = GDM_SESSION_SOLARIS_AUDITOR (auditor);
 
+       if (solaris_auditor->priv->username == NULL)
+               return;
+
        g_return_if_fail (solaris_auditor->priv->username != NULL);
 
        adt_ah = NULL;