Re: [gdm-list] Audit code for GDM

["Ray Strode" <halfline gmail com>]

Hi again,

> > > I suspect that you might want to clean this code up a bit.  It
> > > might be nicer if it were making use of GObjects and subclassing
> > > rather than #ifdef's.  Not sure...
> > Looking through the patch I think there are a few things we can do to
> > clean things up a bit.  I don't have time to do a run through right
> > now though.  I'll try to post some comments/patches early next week.
>
> So, I took your patch and wrapped it inside gobjects, so that it fits
> in with the overall style of the rest of the code.
>
> Patch attached.  I'd appreciate it you could review it and test it.

I've put an updated patch up here:

http://www.gnome.org/~halfline/gdm-audit.patch

This patch addresses a few issues Brian found on IRC, and adds caching
to the solaris auditing code so that getpwnam() doesn't get called
several times.

--Ray