Re: [gdm-list] at-spi-registryd not starting automatically in gdm [was multiple at-spi...]

[Brian Cameron <Brian Cameron Sun COM>]

Dan:

I don't think Francesco needs to really test this change.  The patch
looks right and it should work.  I'd say that the build folks at
Ubuntu should probably just make sure this patch fixes GDM to set
this value properly.  As long as Francesco knows how to workaround
the problem, he can continue with his development work.  Another
workaround would just be to create a symlink.

> On 8/31/07, Brian Cameron <Brian Cameron sun com> wrote:
> > One minor difference, you need to use this code (already in configure.ac)
> > to get the right libexecdir value:
> >
> > if test ${libexecdir} = "\${exec_prefix}/libexec"; then
> >     ssh_libexec="$real_gdm_prefix/libexec"
> > else
> >     ssh_libexec="${libexecdir}"
> > fi

No, it shouldn't be necessary to redo the test, just to use the
right libexec value that the script already gets by doing this test
the first time.  I've updated the patch - I think this approach is
a bit better.

> I put this part into my patch to be consistent, but I don't think it's
> necessary, and it's still error prone. What if I, for some reason, I
> set --libexecdir='${libdir}'? It's not necessary here since the
> variables are used in the Makefile and they will be recursively
> resolved by make. Also, wouldn't it be better to use AS_AC_EXPAND like
> elsewhere in configure.ac? Then, at least you're being consistent with
> the hack.

I think you misunderstand this.  The code is checking to see if
libexecdir contains a literal string of '${exec_prefix}' (an
unresolved variable, in other words).  If so, it just expands
the variable for you.  Otherwise you get an invalid directory.
If you actually set libexecdir to something by using the
--libexecdir flag, then the value you specify will be used.

It would probably be better to use something like AS_AC_EXPAND.  If
you wanted to provide a tested patch that fix the way configure.ac is
doing this, I'd be delighted.

Brian

Index: configure.ac
===================================================================
--- configure.ac	(revision 5213)
+++ configure.ac	(working copy)
@@ -937,15 +937,25 @@
 fi
 
 if test ${libexecdir} = "\${exec_prefix}/libexec"; then
-   ssh_libexec="$real_gdm_prefix/libexec"
+   gdm_libexec="$real_gdm_prefix/libexec"
 else
-   ssh_libexec="${libexecdir}"
+   gdm_libexec="${libexecdir}"
 fi
 
+AC_ARG_WITH(atspi-dir,
+  [  --with-atspi-dir=<PATH>   PATH to at-spi-registryd [default=LIBEXECDIR]])
++
+if ! test -z "$with_atspi_dir"; then
+  ATSPI_DIR="$with_atspi_dir"
+else
+  ATSPI_DIR="$gdm_libexec"
+fi
+AC_SUBST(ATSPI_DIR)
+
 if test x$enable_secureremote != xno ; then
        SSHDESKTOP="ssh.desktop"
         GDMSSHSESSION="gdm-ssh-session"
-        GDMSSHSESSIONCMD="${ssh_libexec}/gdm-ssh-session"
+        GDMSSHSESSIONCMD="${gdm_libexec}/gdm-ssh-session"
 fi
 AC_SUBST(SSHDESKTOP)
 AC_SUBST(GDMSSHSESSION)