Re: [gdm-list] Security?

[Mike Oliver <Mike Oliver Sun COM>]

Ray Strode wrote:
> Hi,
>
> > If it isn't clear (it seems like it's not from your responses) I'm not
> > tied to the g_rand_* apis at all, though.  I'm in the process of
> > rewriting the code to use /dev/urandom.
> I just commtted this patch to subversion:
>
> http://www.gnome.org/~halfline/urandom.patch

In _read_bytes(), the variable 'bytes_left_to_read' is never
initialised.  You need something like:

-    size_t bytes_left_to_read;
+    size_t bytes_left_to_read = number_of_bytes;

Mike.
--
mike oliver sun com