Re: [gdm-list] Security?

["Ray Strode" <halfline gmail com>]

Hi,

> > In _read_bytes(), the variable 'bytes_left_to_read' is never
> > initialised.  You need something like:
> >
> > -    size_t bytes_left_to_read;
> > +    size_t bytes_left_to_read = number_of_bytes;
>
> Also, gdm_generate_random_bytes() leaks a file descriptor on
> every successful open() of /dev/urandom, which on a working
> system will be every time the function is called.
Thanks for the review.  I've committed fixes for those issues.

--Ray