Re: [gdm-list] Hiding Failsafe options under Session menu

[Brian Cameron <Brian Cameron Sun COM>]

Greg:

Thanks for bringing this to my attention.  I notice the problem too,
and just fixed it in CVS head and the 2.14 branch.  If you want to
use the attached patch when you build GDM, it should fix your
problem, or wait until the next 2.14 (stable)/2.15 (unstable)
release.

Brian


> To preface:
>
> I have looked around and the only instance of this issue that I have 
> found was another user having the exact same problem with no solution.
> We are both trying to make a kiosk with Fedora Core 5. I realize that 
> this could be a FC5 issue, so I am going to describe the issue, and ask 
> if anyone on this list not using FC5 is having the issue. If you aren't, 
> I'll go figure out who to report it to w/ the Fedora Project. (My 
> reasoning here is that I could go ask them all day, and since they would 
> be running FC5's gnome 2.14, they would all have the issue, where as you 
> nice people are probably not.).
>
> With that out of the way...
>
> In GDM's custom.conf, under the [greeter] section there are two options 
> that do not seem to be working, here is the excerpt of their default 
> states (on FC5) from <share>/gdm/defaults.conf
>
> ShowGnomeFailsafeSession=false
> #ShowXtermFailsafeSession=true
>
> However these are set, they still show under the Session selection. I 
> enabled debug, and it appeared to be reading the settings properly (I 
> don't have a copy of the log right now cause that box is in transport), 
> just not acting on it.
>
> Anyone not running FC5's build of Gnome 2.14 experiencing this issue?
>
> The most recent RPM versions from FC5 that I believe are related:
>
> gnome-session-2.14.1-1.fc5.1
> gdm-2.14.4-1.fc5.1
>
> Thanks for your time.
>
> -Greg

Index: gdm2/gui/gdmsession.c
===================================================================
RCS file: /cvs/gnome/gdm2/gui/gdmsession.c,v
retrieving revision 1.10
diff -u -r1.10 gdmsession.c
--- gdm2/gui/gdmsession.c	8 Feb 2006 00:56:49 -0000	1.10
+++ gdm2/gui/gdmsession.c	12 May 2006 19:43:42 -0000
@@ -111,7 +111,6 @@
     GdmSession *session = NULL;
     gboolean some_dir_exists = FALSE;
     gboolean searching_for_default = TRUE;
-    gboolean show_xterm_failsafe;
     struct dirent *dent;
     char **vec;
     char *name;
@@ -275,7 +274,6 @@
 	gdm_common_error ("%s: Session directory <%s> not found!",
 		"gdm_login_session_init", ve_sure_string
 		 (gdm_config_get_string (GDM_KEY_SESSION_DESKTOP_DIR)));
-	show_xterm_failsafe     = TRUE;
 	session_dir_whacked_out = TRUE;
     }
 
@@ -284,14 +282,11 @@
 		ve_sure_string (gdm_config_get_string (GDM_KEY_SESSION_DESKTOP_DIR)));
 
 	    session_dir_whacked_out = TRUE;
-	    show_xterm_failsafe     = TRUE;
 	    default_session         = g_strdup (GDM_SESSION_FAILSAFE_GNOME);
     }
 
-    if (gdm_config_get_bool (GDM_KEY_SHOW_XTERM_FAILSAFE))
-	    show_xterm_failsafe = TRUE;
 
-    if (show_xterm_failsafe) {
+    if (gdm_config_get_bool (GDM_KEY_SHOW_GNOME_FAILSAFE)) {
 	    session          = g_new0 (GdmSession, 1);
 	    session->name    = g_strdup (_("Failsafe _GNOME"));
 	    session->comment = g_strdup (_("This is a failsafe session that will log you "
@@ -303,7 +298,7 @@
 		g_strdup (GDM_SESSION_FAILSAFE_GNOME), session);
     }
 
-    if (show_xterm_failsafe) {
+    if (gdm_config_get_bool (GDM_KEY_SHOW_XTERM_FAILSAFE)) {
 	    session          = g_new0 (GdmSession, 1);
 	    session->name    = g_strdup (_("Failsafe _Terminal"));
 	    session->comment = g_strdup (_("This is a failsafe session that will log you "