[gdm-list] Re: build selected modules without gnome deps
- From: Jani Monoses <jani monoses gmail com>
- To: gdm-list gnome org
- Subject: [gdm-list] Re: build selected modules without gnome deps
- Date: Tue, 13 Dec 2005 13:31:17 +0200
Thanks Brian for commiting the patch!
> + Many GDM GUI programs suck in gnome_program_locate_file() which is
> used in ve_find_file() function in vicious-extensions/ve-gnome.c.
> No GDM GUi program calls ve_find_file() directly but a number of
> vicious-extensions functions that are used (glade_helper_load for
> example) do call this function. I'm not sure what this should be
> using instead of gnome_program_locate_file(). Advice or help?
vicious seems to have both gnome and non-gnome variants. I have built
things against the non-gnome ones and it looks ok, the functions you
mention have different implementations there but they hopefully work.
Attached the patch against gui/Makefile.am. If it's ok all references to
vicious-gnome can be purged from configure.ac and
vicious-extensions/Makefile.am
> + The gnome_help_display_uri issue is still there in gdmsetup.c. I'm
> not sure what to do about this one.
One solution would be execve ('gnome-open ghelp:gdm'), maybe first
checking if the program is installed (On debian it is part of the
libgnome2-0 package) I hope this is present in gnome on all distros. If
gnome-open or yelp are not present it would be nice the help button to
be greyed out too :)
This way it would build without gnome deps but it could take advantage
of gnome programs if available.
Jani
--- ../upstream/gui/Makefile.am 2005-12-13 08:50:27.000000000 +0200
+++ gui/Makefile.am 2005-12-13 13:25:11.000000000 +0200
@@ -144,8 +144,8 @@
$(GDK_LIBS) \
$(GDKPIXBUF_LIBS) \
$(EXTRA_SETUP_LIBS) \
- $(LIBGNOMEUI_LIBS) \
- $(top_builddir)/vicious-extensions/libviciousui-gnome.a
+ $(LIBGNOMEUI_LIBS) \
+ $(top_builddir)/vicious-extensions/libviciousui.a
gdmphotosetup_LDADD = \
libgdmcommon.a \
@@ -156,8 +156,7 @@
$(GDK_LIBS) \
$(GDKPIXBUF_LIBS) \
$(INTLLIBS) \
- $(LIBGNOME_LIBS) \
- $(top_builddir)/vicious-extensions/libviciousui-gnome.a
+ $(top_builddir)/vicious-extensions/libviciousui.a
gdmXnestchooser_LDADD = \
libgdmcommon.a \
@@ -170,8 +169,7 @@
$(GOBJECT_LIBS) \
$(GDK_LIBS) \
$(EXTRA_XNEST_LIBS) \
- $(LIBGNOME_LIBS) \
- $(top_builddir)/vicious-extensions/libviciousui-gnome.a
+ $(top_builddir)/vicious-extensions/libviciousui.a
gdmflexiserver_LDADD = \
libgdmcommon.a \
@@ -183,8 +181,7 @@
$(GOBJECT_LIBS) \
$(GDK_LIBS) \
$(EXTRA_FLEXI_LIBS) \
- $(LIBGNOME_LIBS) \
- $(top_builddir)/vicious-extensions/libviciousui-gnome.a
+ $(top_builddir)/vicious-extensions/libviciousui.a
gdmdynamic_LDADD = \
libgdmcommon.a \
@@ -195,8 +192,7 @@
$(GOBJECT_LIBS) \
$(GDK_LIBS) \
$(EXTRA_DYNAMIC_LIBS) \
- $(LIBGNOME_LIBS) \
- $(top_builddir)/vicious-extensions/libviciousui-gnome.a
+ $(top_builddir)/vicious-extensions/libviciousui.a
Settingsdir = $(datadir)/applications
Settings_files = gdmphotosetup.desktop
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]