Re: [gdm-list] [PATCH] missing tooltips

[Rodrigo Moya <rodrigo novell com>]

On Mon, 2005-08-22 at 11:52 -0500, Brian Cameron wrote:
> Rodrigo:
> 
> >>>Yes looks good.  Please apply to both the 2.12 and CVS head branches.
> >>>
> >>ok, committed to both branches, along with, by mistake, another patch I
> >>had prepared to be sent that fixes 64 bit compilation. This is what I
> >>have committed, with its ChangeLog.
> >>
> >>Let me know if it looks good, and I'll commit the ChangeLog. If not,
> >>I'll revert it.
> >
> > did the patch committed by mistake look good or not? Should I commit it
> > to the branch also? revert it?
> 
> I did a "cvs diff -D" to include below the changes you made.  It seems
> the only changes made aside from the tooltips is adding gdmcommon.h
> and ve-miscui.h as includes in gdmwm.c.  It isn't clear to me how this
> would fix 64-bit compilation.  Could you explain?
> 
yes, functions with no prototype is an error in 64bit platform.
-- 
Rodrigo Moya <rodrigo novell com>