Re: [gdm-list] [PATCH] missing tooltips

[Brian Cameron <Brian Cameron Sun COM>]

Rodrigo:

> > > Yes looks good.  Please apply to both the 2.12 and CVS head branches.
> > ok, committed to both branches, along with, by mistake, another patch I
> > had prepared to be sent that fixes 64 bit compilation. This is what I
> > have committed, with its ChangeLog.
> >
> > Let me know if it looks good, and I'll commit the ChangeLog. If not,
> > I'll revert it.
>
> did the patch committed by mistake look good or not? Should I commit it
> to the branch also? revert it?

I did a "cvs diff -D" to include below the changes you made.  It seems
the only changes made aside from the tooltips is adding gdmcommon.h
and ve-miscui.h as includes in gdmwm.c.  It isn't clear to me how this
would fix 64-bit compilation.  Could you explain?

Brian



===================================================================
RCS file: /cvs/gnome/gdm2/ChangeLog,v
retrieving revision 1.1197
retrieving revision 1.1198
diff -r1.1197 -r1.1198
0a1,5
> 2005-08-17  Rodrigo Moya <rodrigo novell com>
>
>       * gui/greeter/greeter_system.c (greeter_system_handler): added
>       missing tooltips.
>
Index: gui/gdmwm.c
===================================================================
RCS file: /cvs/gnome/gdm2/gui/gdmwm.c,v
retrieving revision 1.30
retrieving revision 1.31
diff -r1.30 -r1.31
37a38
> #include "gdmcommon.h"
38a40
> #include "ve-miscui.h"
Index: gui/greeter/greeter_system.c
===================================================================
RCS file: /cvs/gnome/gdm2/gui/greeter/greeter_system.c,v
retrieving revision 1.30
retrieving revision 1.31
diff -r1.30 -r1.31
319a320,322
>         gtk_tooltips_set_tip (tooltips, GTK_WIDGET (restart_radio),
>                               _("Reboot your computer"),
>                               NULL);
333a337,339
>         gtk_tooltips_set_tip (tooltips, GTK_WIDGET (suspend_radio),
>                               _("Suspend your computer"),
>                               NULL);