Re: [PATCH] GDM-2.4.4.5 Alternative display optional info message before login

[Anton Altaparmakov <aia21 cam ac uk>]

On Thu, 2003-11-06 at 18:00, George wrote:
> On Tue, Nov 04, 2003 at 01:41:23PM +0000, Anton Altaparmakov wrote:
> > > I'm not sure I truly like this path to customizing the font and color
> > > there. We're not really talking about an "item" in the theme, so it
> > > really seemslike an utter hack.  What could really happen is for the
> > > file to use pangomarkup optionally (or maybe just always use it, I don't
> > > think pango markup is dangerous in any way).  This way you could not
> > > only specify a font for the whole thing, but you could change how
> > > certain parts of it look etc...  I suppose for any sort of "usage rules"
> > > it would be useful to make certainparts larger and bold :)
> > 
> > For us using Pango is not an option because we share the same file with
> > Windows.  )-:
> 
> Well I suppose still using pango markup will be useful for other people, so
> I'd also go with using markup in the label, rather then just gtk_label_new.

I guess so.  But I will leave that as an exercise for someone else. 
Possible problem I can see are things like <, >, and most frequently &
present in the text which will suddenly be considered as special
characters so there is a potential pitfal with Pango markup here...

> > However to address your "utter hack" objections, I have removed the
> > fontsize changes through the theme and have added a new gdm.conf option
> > "InfoMsgFont" (goes together with the "InfoMsgFile" specifying the file
> > itself). So InfoMsgfont=Sans 24 for example would modify the font
> > description before displaying the file contents to use Sans 24 font loaded
> > using pango_font_description_from_string().
> > 
> > I hope this is an acceptable alternative for you.
> 
> This is very acceptable.  One thing though, can you make a patch for the docs
> as well? (docs/C/gdm.xml)

Attached to this email is a patch to docs/C/gdm.xml which adds
appropriate descriptions for the new options my patch introduces.

Let me know if you would like me to resubmit both patches as one
combined one...

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ &
http://www-stu.christs.cam.ac.uk/~aia21/

--- gdm-2.4.4.5.old/docs/C/gdm.xml	2003-10-06 22:23:24.000000000 +0100
+++ gdm-2.4.4.5/docs/C/gdm.xml	2003-11-10 15:18:49.000000000 +0000
@@ -1280,6 +1280,34 @@
 	  </varlistentry>
 	  
 	  <varlistentry>
+	    <term>InfoMsgFile</term>
+	    <listitem>
+	      <synopsis>InfoMsgFile=/path/to/infofile</synopsis>
+	      <para>
+		If present and /path/to/infofile specifies an existing and
+		readable text file (e.g. /etc/infomsg.txt) the contents of the
+		file will be displayed in a modal dialog box before the user
+		is allowed to login.
+		This works both with the standard and the themable greeters.
+	      </para>
+	    </listitem>
+	  </varlistentry>
+	  
+	  <varlistentry>
+	    <term>InfoMsgFont</term>
+	    <listitem>
+	      <synopsis>InfoMsgFont=fontspec</synopsis>
+	      <para>
+		If present and InfoMsgFile (see above) is used, this specifies
+		the font to use when displaying the contents of the InfoMsgFile
+		text file.  For example fontspec could be Sans 24 to get a
+		sans serif font of size 24 points.
+		This works both with the standard and the themable greeters.
+	      </para>
+	    </listitem>
+	  </varlistentry>
+	  
+	  <varlistentry>
 	    <term>KillInitClients</term>
 	    <listitem>
 	      <synopsis>KillInitClients=true</synopsis>