Re: [PATCH] GDM-2.4.4.5 Alternative display optional info message before login

[George <jirka 5z com>]

On Tue, Nov 04, 2003 at 01:41:23PM +0000, Anton Altaparmakov wrote:
> > I'm not sure I truly like this path to customizing the font and color
> > there. We're not really talking about an "item" in the theme, so it
> > really seemslike an utter hack.  What could really happen is for the
> > file to use pangomarkup optionally (or maybe just always use it, I don't
> > think pango markup is dangerous in any way).  This way you could not
> > only specify a font for the whole thing, but you could change how
> > certain parts of it look etc...  I suppose for any sort of "usage rules"
> > it would be useful to make certainparts larger and bold :)
> 
> For us using Pango is not an option because we share the same file with
> Windows.  )-:

Well I suppose still using pango markup will be useful for other people, so
I'd also go with using markup in the label, rather then just gtk_label_new.

> However to address your "utter hack" objections, I have removed the
> fontsize changes through the theme and have added a new gdm.conf option
> "InfoMsgFont" (goes together with the "InfoMsgFile" specifying the file
> itself). So InfoMsgfont=Sans 24 for example would modify the font
> description before displaying the file contents to use Sans 24 font loaded
> using pango_font_description_from_string().
> 
> I hope this is an acceptable alternative for you.

This is very acceptable.  One thing though, can you make a patch for the docs
as well? (docs/C/gdm.xml)

George

-- 
George <jirka 5z com>
   History will be kind to me for I intend to write it.
                       -- Winston Churchill