Re: libgtop problem

[Jens Bech Madsen <jbm oncable dk>]

On Wed, 2003-11-05 at 22:35, ZHAO Wei wrote:
> Jens Bech Madsen wrote:
> > A warning normally shouldn't stop the compile. If it does, you can
> > remove -Werror from the Makefiles in the libgtop work directories. That
> > should stop errors from being treated as errors (it should say so right
> > before the warning if that is the case).
> 
> Oh yeah! Sorry me! 8) Now I went back some screens and I saw the error 
> now, but still I don't know how I could fix this. The system is Debian 
> unstable which just introduced a linux-kernel-headers package several 
> days ago. Don't know if it is related, though.
> 
> In file included from /usr/include/linux/timer.h:5,
>                   from /usr/include/linux/isdn/fsm.h:15,
>                   from /usr/include/linux/isdn.h:17,
>                   from ppp.c:29:
> /usr/include/linux/list.h:576:2: warning: #warning "don't include kernel 
> headers in userspace"
> 
> 
> The above message is telling but I don't know how I could do the fix. 8(
> 
> 
> In file included from /usr/include/linux/timer.h:6,
>                   from /usr/include/linux/isdn/fsm.h:15,
>                   from /usr/include/linux/isdn.h:17,
>                   from ppp.c:29:
> /usr/include/linux/spinlock.h: In function `bit_spin_lock':
> /usr/include/linux/spinlock.h:413: error: invalid type argument of `->'
> /usr/include/linux/spinlock.h: In function `bit_spin_trylock':
> /usr/include/linux/spinlock.h:430: error: invalid type argument of `->'
> /usr/include/linux/spinlock.h:433: error: invalid type argument of `->'
> /usr/include/linux/spinlock.h:433: error: `TIF_NEED_RESCHED' undeclared 
> (first use in this function)
> /usr/include/linux/spinlock.h:433: error: (Each undeclared identifier is 
> reported only once
> 
> And there're several more related to this ppp.c file which is
> 
> garnome-0.27.1/gnome/libgtop/work/main.d/libgtop-2.0.5/sysdeps/linux/ppp.c
> 
> BTW, thanks for the quick reply! 8)


Just ran the build myself. I get the same errors. And you're right, it
seems to be related to the new glibc kernel headers. My guess is that
ppp.c should use the isdn.h in /usr/i486-linuxlibc1/include/linux/isdn.h
instead of the one in /usr/include. I messed around with the include
dirs a little bit without luck. We might need someone with greater
knowledge than me to get this working...

According to Daniel Jacobowitz (one of the Debian glibc maintainers)
programs which use the glibc kernel headers are broken and should be
fixed, so I guess this is something the gtop people should look at.


Cheers,
Jens