Re: [gamin] [PATCH 1 of 3] Apple ld does not support version-script

[Brendan Cully <brendan kublai com>]

On Wednesday, 04 July 2007 at 09:42, Daniel Veillard wrote:
> On Sat, May 05, 2007 at 03:39:51PM -0700, Brendan Cully wrote:
> > # HG changeset patch
> > # User Brendan Cully <brendan kublai com>
> > # Date 1178392905 25200
> > # Node ID 195b3607f4f77ca752bc954ee4293c0a27686814
> > # Parent  bb83e73fd41095d98c8a83e21a717ffac1f53151
> > Apple ld does not support version-script
> 
>   Sorry for coming back late to this but I didn't really had cycles for 
> it before.

> >  
> >  libfam_la_SOURCES = $(libgamin_1_la_SOURCES)
> >  libfam_la_LIBADD = $(libgamin_1_la_LIBADD)
> > -libfam_la_LDFLAGS = -Wl,--version-script=$(srcdir)/gamin_sym.version	\
> > -                    -version-info @FAM_VERSION_INFO@ @THREAD_LIBS@
> > +libfam_la_LDFLAGS = -version-info @FAM_VERSION_INFO@ @THREAD_LIBS@
> > +
> > +if GNU_LD
> > +libfam_la_LDFLAGS += -Wl,--version-script=$(srcdir)/gamin_sym.version
> > +endif
> >  
> >  #
> >  # Compile a program locally to check
> 
>   The problem with this patch is that instead of detecting OSX it detects
> the kind of linker. Plus it doesn't replace the filtering of symbols which

I was under the impression that --version-script was a GNU-specific LD
flag. Are there other versions of LD that understand it? Generally I'd
rather target the linker than the platform to produce linker flags.

> is the point about libgamin/gamin_sym.version , as a result all symbols
> from libgamin would be exported in the resulting shared lib and I really
> think it's not proper, we just want the FAM symbols to be usable from 
> applications and nothing else.

I agree, but I don't know how to hide the other symbols on OS X.