Re: [gamin] [patch] gamin bus error on sparc

On Fri, Sep 09, 2005 at 02:58:26PM +0200, Sjoerd Simons wrote:
> On Thu, Sep 08, 2005 at 12:30:02PM -0400, Daniel Veillard wrote:
> >   I realized I didn't processed your patch. While Unaligned accesses
> > can be extremely expensive or prohibited on some arches on others the
> > penalty is quite lower than memmov'ing the whole set of data read 
> > each time a new fragment is processed. So I would really prefer a 
> > patch conditional to your architecture. But I can't test it and
> > I'm not sure #ifdef sparc is a portable macro for this. Can you check ?
> Afaik #ifdef __sparc__ is portable.. But i would suggest doing it the other
> way around. That is do memmov by default and only use potential unaligned
> access on arch where it's known to be allowed and cheap enough. 
> Patch attached which does potentially unalligned access on i386 and memmove on
> others.

  Okay, I just had to change that to
    #if defined(__i386__) || defined(__x86_64__)
to keep the fast path on x86_64 arches.
Applied it seems to pass the tests, I should commit it soon,



Daniel Veillard      | Red Hat Desktop team
veillard redhat com  | libxml GNOME XML XSLT toolkit | Rpmfind RPM search engine

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]