Re: [gamin] inotify cleanup

[Daniel Veillard <veillard redhat com>]

On Wed, Jul 13, 2005 at 02:07:31PM -0400, John McCutchan wrote:
> Yo,
> 
> Here is another inotify cleanup patch...

  Hum, you should separate the patches, or we provide you CVS access...
Adding comments about what the patch does would help too.

the _syscall0(int, inotify_init); constructs didn't work here:

gam_inotify.c:60: error: syntax error before "inotify_init"
gam_inotify.c:60: warning: type defaults to `int' in declaration of `_syscall0'
gam_inotify.c:60: warning: data definition has no type or storage class
gam_inotify.c:61: error: syntax error before "inotify_add_watch"
gam_inotify.c:61: warning: type defaults to `int' in declaration of `_syscall3'
gam_inotify.c:61: warning: data definition has no type or storage class
gam_inotify.c:62: error: syntax error before "inotify_rm_watch"
gam_inotify.c:62: warning: type defaults to `int' in declaration of `_syscall2'
gam_inotify.c:62: warning: data definition has no type or storage class
make[3]: *** [gam_inotify.o] Error 1

  possibly die to the fact that I am compiling on a system where 
inotify is not installed. Please don't assume this, even if inotify is
the direction we should focuse on, 

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/