Re: [gamin] Test suite problems

[Daniel Veillard <veillard redhat com>]

On Mon, Aug 01, 2005 at 07:21:11PM -0400, John McCutchan wrote:
> In the actual test the directory does exist. Well, I think this is silly
> but if the FAM documentation says it must be this way. It must be :)

  FAM is silly :-) The documentation covers only a tiny subset 
of all the different cases, then it's just a backward compatibility
game "application foo used but work with famd but with gamin ..."
It's not terribly fun but well it's gamin's contract :-)

> I wasn't trying to deny that the test passed on my machine. I was trying to 
> make the point that on someone elses machine, the tests might fail.

  Yes though in general it was relatively reliable, it's just 
a mechanism to avoid mistakes and try to increase confidence in the
code. It's not perfect , can't be perfect I guess, but should definitely
be improved if possible.

> > > Also, looking at the dnotify kernel code and considering the DELETE
> > > event. There is nothing that guarantees that by the time you receive the
> > > DELETE event in gam_server the file will actually be removed from the
> > > directory tree.
> > 
> >   So far that expectation has never be seen as broken in normal testing.
> > To me it's a kernel bug like inotify bug you fixed 2 weeks ago it may just
> > be a race instead of being systematic.
> 
> I agree that the kernel should only send the event after the file has
> been removed from the filesystem. But, currently the dnotify kernel code
> makes no guarantees (it just so happens that by the time gam_server
> looks for the file it's gone.) The reason is succeeds is because
> the events are being delivered by signal which takes more time than the
> events being delivered over an inotify FD.

  what about adding an explicit delays, the pythons tests are already full
of them. And sure this won't mak it perfect, it just decrease the probability
of false error reports, the kernels provide no timing garantee.

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/