[gamin] Re: [PATCH] inotify 0.5

[John McCutchan <ttb tentacle dhs org>]

On Wed, Jul 28, 2004 at 09:24:01AM -0400, Daniel Veillard wrote:
> On Tue, Jul 27, 2004 at 11:35:30PM -0400, John McCutchan wrote:
> > >   yup, you don't want to delay the event, but block successive Changed events
> > > until a given delay. This can be done completely server based.
> > 
> > I am working on this right now. For each connection I have added a queue
> > of changes, and then when an event comes down that is already in the
> > queue I just toss it out (What about reqno's?). After a set delay the
> > queue gets flushed and all events get sent down the fd. How does this
> > sound?
> 
>   reverse than I would suggest. Do not delay the first event. But delay
> future similar events. Might be doable in your current design by switching
> slightly how items are queued and processed (adding a 'sent' flag to events).
> 

What I could do is for each subscription have a slot for each event
type that includes the time the last event was sent. Then if an event
comes and the last time it was sent is
passed a certain thershold send it again. The only thing I could see not
working is if the last event came to soon, then nautilus wouldn't
recieve the final event.

> > 2) Why do we send EXIST events? This doesn't really mesh well with
> 
>   backward compatibility with FAM, please do not change.
> 
> > inotify since you can't watch anything in inotify until it exists.
> 
>   that need to be fixed too with dnotify, see TODO.

For now I will just send an EXIST event when ever a new
subscription is added.
> 
> > 3) When I am using the dnotify backend and I create a file in a
> > directory being watched I get 2 Create events one with just the filename
> > and the second with the full path name. Is this a bug or what?
> 
>   Not normal. Didn't show up in my own tests

What is the correct event? filename or fullpath?

> 
> > 4) What is gamin supposed to mean?
> 
>   like marmot it's a familiar word for kid.

It's not a familiar word for me.

John