Re: with-gtk

["Thomas H.P. Andersen" <phomes gmail com>]

On Wed, Nov 3, 2010 at 19:59, Thomas H.P. Andersen <phomes gmail com> wrote:
> something like:
>
> diff --git a/configure.in b/configure.in
> index d515b49..a81aa90 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -23,9 +23,9 @@ AM_MAINTAINER_MODE([enable])
>  # we support and which features to check for
>
>  # This is the canonical list of all game subdirectories.
> -allgames="aisleriot quadrapassel gnect gnomine swell-foop mahjongg
> gtali gnotravex gnotski glines iagno glchess gnobots2 gnibbles
> gnome-sudoku lightsoff"
> +allgames="aisleriot glines gnect gnotski gtali"
>  AC_SUBST([allgames])
> -staginggames=""
> +staginggames="quadrapassel gnomine swell-foop mahjongg gnotravex
> iagno glchess gnobots2 gnibbles gnome-sudoku lightsoff"
>  AC_SUBST([staginggames])
>
>  gamelist=""
> @@ -323,12 +323,12 @@ fi
>
>  AC_MSG_CHECKING([which gtk+ version to compile against])
>  AC_ARG_WITH([gtk],
> -  [AS_HELP_STRING([--with-gtk=2.0|3.0],[which gtk+ version to compile
> against (default: 2.0)])],
> +  [AS_HELP_STRING([--with-gtk=2.0|3.0],[which gtk+ version to compile
> against (default: 3.0)])],
>   [case "$with_gtk" in
>      2.0|3.0) ;;
>      *) AC_MSG_ERROR([invalid gtk version specified]) ;;
>    esac],
> -  [with_gtk=2.0])
> +  [with_gtk=3.0])
>  AC_MSG_RESULT([$with_gtk])
>
>  if test "$with_gtk" = "2.0" -a "$allow_gtk2" = "no"; then
>
>
> On Wed, Nov 3, 2010 at 19:45, Christian Persch <chpe gnome org> wrote:
>> Hi;
>>
>> Am Wed, 3 Nov 2010 19:39:11 +0100
>> schrieb "Thomas H.P. Andersen" <phomes gmail com>:
>>> any reason not to make --with-gtk=3.0 the default? (Primarily to make
>>> build.gnome.org happier/more useful)
>>
>> No objections here. But you should adjust the default value of the
>> --with-games switch, so not 'all' but only those games are built
>> that already support gtk3.
>>
>> Regards,
>>        Christian
>>
>

The buildbot now completed the first successful build in a long time.
Check still seems to fail with some strange errors (mentioning
blackjack, gnometris, and same-gnome) but at least it builds.
http://build.gnome.org/gnome-games