Re: [pkg-ggz-maintainers] [Secure-testing-team] A case of large code duplication

["Roger Light" <roger atchoo org>]

On Sat, Sep 29, 2007 at 08:18:13AM +0200, Josef Spillner wrote:
>
> Il Saturday 29 September 2007 02:39:57 Josselin Mouette ha scritto:
> > It would require quite some work to keep both versions in sync, and
> > until now even trivial changes I have proposed like new translations
> > haven't been integrated by the Debian ggz team, so I don't think there
> > is enough will to do that.
> 
> Talking from an upstream perspective (and therefore including gnome-games into 
> the CC list):
> 
> We have recently added a script in GGZ SVN:
> 	trunk/playground/maintenance/diff-to-gnome.sh
> Its output is available here:
> 	http://hq.ggzgamingzone.org/~josef/diff-to-gnome/
> (Unfortunately this particular server seems to be unreachable right now, I'll 
> try to fix this or relocate the diff files.)

I've created a set of tidied up diffs at
http://www.ggzgamingzone.org/~oojah/diff/ I've stripped out all of the
changes like SVN $Id$ updates and where extra functionality has been
added to ggz since the gnome guys last updated from our svn (which was
the overwhelming majority of the differences) as well as removing the 
diffs where the changes have already been merged back into our trunk.

After removing all of those, the only thing I can see that remains to be
changed in the non-gui libraries is the LOCALEDIR definition in ggzcore 
which has been added by gnome games. I've not checked it yet, but it
should only be short while to verify and test that change.

That still leaves the ggz-gtk library which as Josselin mentioned
includes many more changes, but getting the non-gui libraries out should
go a long way to helping.

> Now that gnome-games 2.20 is out, it is the right time to start the cleanup.

Agreed.

Cheers,

Roger