patch review: patch 51377 for bug 314559: Be able to scale pictures when sending an e-mail
- From: Stephane Delcroix <stephane delcroix org>
- To: f-spot-list <f-spot-list gnome org>
- Subject: patch review: patch 51377 for bug 314559: Be able to scale pictures when sending an e-mail
- Date: Tue, 23 May 2006 14:28:28 +0200
patch review: patch 51377 for bug 314559: Be able to scale pictures when
sending an e-mail
Compilation:
- this patch no longer cleanly apply against up-to-date CVS. Things to modify
in SendEmail.cs:
- replace 2 occurences of IPhotoCollection by IBrowsableCollection
- replace all occurences of photo.DefaultVersionPath by
photo.GetVersionPath(photo.DefaultVersionId)
Add attachment:
- is working with Evolution (2.6): the temp image can be removed before sending
e-mail. As Larry suggested, we need to start a timer and then remove the image
- is *NOT* working with Thunderbird at all. A new mail window is opened, but
without any attachment
UI:
- for evolution and with a timeout, remove the dialog.
- when the mail is sent, you always have a dialog with 2 buttons: 'cancel' and
'send mail'. This dialog should disappear.
Missing feature:
- when exporting full-size, rotate according to EXIF (optional)
Without this patch, the Send Mail command is useless !!!
--
Stephane Delcroix
stephane delcroix org
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]