Re: Copy on DnD / Import Fixes - Patch

Thanks Aaron, looks good.  Go ahead and commit.


On Sat, 2005-12-03 at 00:39 -0500, Aaron Bockover wrote:
> Tonight I was in the mood to organize stuff, and felt compelled to clean
> up ~/Photos, reimport everything, and tag everything for real. Up until
> tonight I've just used F-Spot more or less to offload photos from my
> camera.
> I have close to a thousand photos taken a few years back on a really
> cheap digital camera that have never seen F-Spot. This camera was so
> pathetic it apparently didn't even stick a time stamp in EXIF. Luckily
> the mtimes on these photos are at least relatively accurate. 
> Attached is a patch that accomplishes/fixes a few things with importing
> and DnD:
> 1. Importing the photos with no EXIF timestamps with the "copy" option
> reads the photo for metadata _after_ the copy - this hoses the mtimes,
> and leaves me with a thousand photos "taken" today. This is fixed by
> passing both the new/destination and old/source path (which can be
> identical if a copy was not performed) to PhotoStore.Create. It will
> parse the data from the old/source path and do everything else on the
> new/dest path. Makes me happy ;)
> 2. Respect the DragAction for DnD files from Nautilus to F-Spot for
> importing. If you effectively DnD with the Gdk.DragAction.Copy flag, the
> photos will be copied and imported. If you drag with
> Gdk.DragAction.Move, they will not be copied. 
> This modifies the default behavior: DnD with no key modifiers will copy
> and import. You have to hold "Shift" and DnD to not copy. Since this
> changes the current default behavior, maybe this needs to be discussed.
> I think it's sane however since the Move/Copy is set from Nautilus, and
> is how Nautilus itself works. (The previous functionality of this I
> think is *incorrect*. I always assumed F-Spot copied my photos when I
> had the copy modifier set for the drag.
> 3. Finally, a little teeny bug fix. When performing any kind of DnD
> import, F-Spot would crash after the import because it was trying to
> update the label on the import progress dialog. I assume this was
> introduced recently as it didn't used to happen. Was just a little null
> ref.
> So now I'm happy and organized and can actually find photos now :)
> Best,
> Aaron
> _______________________________________________
> F-spot-list mailing list
> F-spot-list gnome org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]