[evolution-patches] Code cleanup patches for Evolution 2.11

[Matthew Barnes <mbarnes redhat com>]

I'm accumulating quite a backlog of outstanding code-cleanup patches and
I'd like to shorten the list now that 2.11 development has begun.

These patches and more are listed on my RedHat Patches wiki page [1].
Many of them have been happily living in Fedora "Rawhide" for a number
of months now.

Consider this a friendly request for some patch review.

Here's the easy ones:

  * Bug 360240 – Fix "unused variable" compiler warnings
    http://bugzilla.gnome.org/show_bug.cgi?id=360240

  * Bug 360619 – Fix "incompatible pointer type" compiler warnings
    http://bugzilla.gnome.org/show_bug.cgi?id=360619

  * Bug 373837 – Migrate from GnomeFontPicker to GtkFontButton
    http://bugzilla.gnome.org/show_bug.cgi?id=373837

  * Bug 405916 – Fix all compiler warnings in evolution-exchange
    http://bugzilla.gnome.org/show_bug.cgi?id=405916

  * Bug 413173 – Refresh the API documentation
    http://bugzilla.gnome.org/show_bug.cgi?id=413173

  * Bug 415891 – Proposal: EFlag -- simple thread synchronization
    http://bugzilla.gnome.org/show_bug.cgi?id=415891

  * Bug 418852 – Miscellaneous Camel clean-ups
    http://bugzilla.gnome.org/show_bug.cgi?id=418852

  * Bug 418971 – Drop support for GLib < 2.8
    http://bugzilla.gnome.org/show_bug.cgi?id=418971


A bit more complex:

  * Bug 373116 – Migrate from GnomeColorPicker to GtkColorButton
    http://bugzilla.gnome.org/show_bug.cgi?id=373116

  * Bug 373117 – Proposal: Change how ESource stores colors
    http://bugzilla.gnome.org/show_bug.cgi?id=373117


These mess with threading logic and require a careful review:

  * Bug 362638 – EThread is obsolete
    http://bugzilla.gnome.org/show_bug.cgi?id=362638

  * Bug 376991 – Refactor e-passwords.c
    http://bugzilla.gnome.org/show_bug.cgi?id=376991


And finally some simple UI suggestions:

  * Bug 383953 – The inbox summary shown in the panel should show
    new mail before the total
    http://bugzilla.gnome.org/show_bug.cgi?id=383953

  * Bug 395927 – Move Cancel button to status bar?
    http://bugzilla.gnome.org/show_bug.cgi?id=395927


Thanks in advance,

Matthew Barnes


[1] http://www.go-evolution.org/RedHat_Patches