Re: [evolution-patches] Conditional jump or move depends on uninitialised value(s)



What's the bug?

Zeroing the internal buffer doesn't seem like a real fix to me... it
might silence the valgrind warnings, but nothing seems to check against
'\0', code only either checks inptr < inend or against inptr !=
'\n' (inend always gets set to '\n' so there should be no way to compare
values past the end of the input afaict)

as far as the other valgrind warnings... well, I can't help but wonder
if this is actually a gcc optimization bug?

I don't like the idea of initializing the entire buffer to 0 if it
doesn't address a real bug because it may end up hiding real bugs.

Jeff

On Wed, 2007-06-27 at 10:57 +0200, Philip Van Hoof wrote:
> Based on what valgrind is giving me, I'm proposing this patch (attached). 
> 
> ==25759== Conditional jump or move depends on uninitialised value(s)
> ==25759==    at 0x417BB66: folder_scan_content (camel-mime-parser.c:1353)
> ==25759==    by 0x417C032: folder_scan_step (camel-mime-parser.c:1662)
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]