Re: [evolution-patches] Bugfix in the maildir code of Camel

[Philip Van Hoof <spam pvanhoof be>]

On Tue, 2007-06-26 at 09:51 -0400, Jeffrey Stedfast wrote:
> the :2 is part of the maildir spec
> 
> the rename() fix is fine
> 

Here's a new patch with a ChangeLog entry.

Please let me know if the entry is fine, so that I can commit this.

-- 
Philip Van Hoof, software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://www.pvanhoof.be/blog



Index: providers/local/camel-maildir-folder.c
===================================================================
--- providers/local/camel-maildir-folder.c	(revision 7841)
+++ providers/local/camel-maildir-folder.c	(working copy)
@@ -191,7 +191,7 @@
 	
 	/* now move from tmp to cur (bypass new, does it matter?) */
 	dest = g_strdup_printf("%s/cur/%s", lf->folder_path, camel_maildir_info_filename (mdi));
-	if (rename (name, dest) == 1)
+	if (rename (name, dest) == -1)
 		goto fail_write;
 
 	g_free (dest);
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 7841)
+++ ChangeLog	(working copy)
@@ -1,3 +1,9 @@
+2007-06-26  Philip Van Hoof  <pvanhoof gnome org>
+
+	* providers/local/camel-maildir-folder.c: Bugfix when renaming from
+	tmp to cur didn't work (which can happen on FAT32 that doesn't allow
+	certain special characters that are used by the Maildir spec).
+
 2007-06-21  Irene Huang  <irene huang sun com>
 
 	* camel-sasl-gssapi.c: (gssapi_challenge): replace gss_nt_service_name