Re: [evolution-patches] Patch for a lot of compiler warnings and some other cleanups in evolution/calendar/*

[chenthill <pchenthill novell com>]

Hi kmaraas,
          The patch looks great !!!

Some comments,

Index: gui/e-day-view-config.c
+	gint not, not_1, not_2;
not should be guint,
the other two variables should be gint and please add another variable
to get the values for the marcus banes line notifications.

Index: gui/e-meeting-list-view.c
-			dl = e_destination_list_get_dests (des);
+			dl = g_list_copy ((GList *)e_destination_list_get_dests (des));
The list should not be copied, as it removes the attendee from the
destination itself, else the removed attendees would be re-added to
meeting editor. 

Index: gui/gnome-cal.c
-		e_calendar_table_copy_clipboard (E_MEMO_TABLE (priv->memo));
e_calendar_table should be changed to e_memo_table.


The rest of the patch looks good to commit. The other parts except the
above mentioned parts can be committed immediately. The patch for the
commented part can be sent for review separately.


thanks, Chenthill.
On Tue, 2006-09-19 at 11:18 +0200, Kjartan Maraas wrote:
> tir, 29,.08.2006 kl. 18.03 +0200, skrev Kjartan Maraas:
> > This probably needs a couple of rounds of review before going in.
> > 
> > - compiler warnings, mostly incompatible pointers being used as
> > arguments or for assignments, also unused variables, signedness issues,
> > implicit declarations etc
> > 
> > - changes to GString handling
> > micro-optimizations because passing the lenght where we know it when
> > appending/prepending to a GString supposedly saves a call to strlen().
> > Same thing for g_string_new("") vs g_string_new(NULL)
> > 
> Rediffed after the latest batch of similar fixes by Matthew.
> 
> Cheers
> Kjartan
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches