Re: [evolution-patches] Hidden agendas and Soft Targets [Was: Re: Warning fixes]

[Pavel Roskin <proski gnu org>]

Hello!

On Wed, 2006-10-18 at 15:31 +0530, Harish Krishnaswamy wrote:
> It is indeed sad you are not going to do any more work on Evolution. But
> is it true that your patches have not been accepted ?

I've been tracking the CVS for some time and I didn't see my warning
fixes applied.  Then I removed the sources.  Nobody has ever told me
that my latest warning fixes have been applied.

I've checked out the CVS again to see what was applied.

> I just grepped the archives for your posts and found this :
> 
> Evolution Hackers :
> 
> 1.
> http://mail.gnome.org/archives/evolution-hackers/2006-August/msg00049.html
> Posted : Sun Aug 13 07:51:24 GMT 2006
> Response : Wed, 16 Aug 2006 11:45:00 +0530 

This is a fix for a problem found by Valgrind.  My patch was wrong
because it tries two things at once - fix the warning and replace
numbers with symbolic names.  The issue is still not addressed in CVS.

That's why I advised Kjartan not to do many things in one patch.  I'm
not sure if my advise was understood though.

> http://mail.gnome.org/archives/evolution-hackers/2006-August/msg00057.html
> Posted : Mon Aug 14 23:58:11 GMT 2006
> Response : Thu, 17 Aug 2006 11:02:55 +0530

This is a fix for crash on 64-bit systems.  This is in CVS and also in
version 2.8.0.

> http://mail.gnome.org/archives/evolution-hackers/2006-August/msg00058.html
> Posted : Mon, 14 Aug 2006 19:58:12 -0400
> Response : Wed, 16 Aug 2006 22:13:02 +0800

This was applied.

> http://mail.gnome.org/archives/evolution-hackers/2006-August/msg00059.html
> Posted : Mon, 14 Aug 2006 19:58:14 -0400
> Response : Tue, 15 Aug 2006 08:50:57 +0000

This was applied.

> Evolution Patches :
> 1.
> http://mail.gnome.org/archives/evolution-patches/2006-September/msg00007.html
> 
> Posted : Thu Sep 21 06:04:53 GMT 2006
> Response : Thu, 21 Sep 2006 08:33:33 -0400  
> 
> This was from Matthew Barnes suggesting one change he would prefer on
> the patch. 
> No follow-ups on the patch.  And this has not been committed yet.

Correct.  I don't think it wasn't committed because I didn't re-send the
patch with that minor change.  Although different projects can have
different rules.  Maybe I should try it.

There was also the discussion whether it's better to file bug reports.
Again, I don't know if that was the reason why my patch wasn't applied.
I can try that too.

In any case, I wasn't not working on any more patches and I didn't have
any indication that any pending patched would be applied, hence my reply
that I don't expect any of my patches to overlap with other patches.

> Pavel : We welcome your contributions - We need you guys - but a
> friendly nudge can help get things moving more than a mail like yours -
> I understand what you must be feeling but please do take a look at
> Bugzilla/CVS sources/your own mailbox to actually look for some evidence
> before making any sweeping generalizations that the team ignores patches
> or does not respect contributions. Such mails shape a lot of incorrect
> perceptions and expectations that I believe are not your intentions but
> these are real consequences to the team and potential contributors
> nevertheless.

I don't think I was making any "sweeping generalizations".  I offered my
advise based on my very limited experience with the project, and my
recommendation was to "go ahead", not to "give up" or to "wait until I'm
done".

> And p-l-e-a-s-e do not let yourself be (mis)used to run somebody else's
> agenda.

I think you misinterpreted my post.

Anyway, it's nice to see people caring about patches.  I think I'll just
resend the remaining stuff.

-- 
Regards,
Pavel Roskin