[evolution-patches] Re: patch to fix #240762(widgets/menus)

[Li Yuan <Li Yuan Sun COM>]

Committed to CVS Head. Thank you very much.

Li

Kaushal Kumar wrote:

> Sorry about the delay. Please go ahead and commit the patch. 
> Thanks for your work,
> Kaushal
>
>  
>
> > > > Li Yuan <Li Yuan Sun COM> 09/27/05 2:15 PM >>>
> > > >        
> Hi Kaushal,
>
> Does Srinivasa return to work? Is my patch OK?
> Li
>
>
> Kaushal Kumar wrote:
>
>  
>
> > On Tue, 2005-09-06 at 12:31 +0000, Li Yuan  wrote:
> >
> >
> >    
> >
> > > Hi Kaushal,
> > >
> > > I have fixed #240762 earlier.
> > >
> > >   
> > >
> > >      
> > (http://cvs.gnome.org/viewcvs/evolution/widgets/menus/gal-define-views-dialog.c?r1=1.29&r2=1.30
> >
> >
> >
> > <http://cvs.gnome.org/viewcvs/evolution/widgets/menus/gal-define-views-dialog.c?r1=1.29&r2=1.30>)
> >
> >
> >    
> >
> > > For I didn't deal with the non-built-in part, Srinivasa made a patch
> > >   
> > >
> > >      
> > to 
> >
> >
> >    
> >
> > > fix it. 
> > >
> > >   
> > >
> > >      
> > (http://cvs.gnome.org/viewcvs/evolution/widgets/menus/gal-define-views-dialog.c?r1=1.32&r2=1.33
> >
> >
> >
> > <http://cvs.gnome.org/viewcvs/evolution/widgets/menus/gal-define-views-dialog.c?r1=1.32&r2=1.33>)
> >
> >
> >    
> >
> > > But the latter patch reproduce the bug. 
> > >   
> > >
> > >      
> > You mean the bug did not get fixed fully? i.e. in which manner is the
> > problem being reproduced? could you elaborate please. Do we have a
> >    
> filed
>  
>
> > bugzilla bug number?
> >
> >
> >
> >    
> >
> > > Now I have a new patch to fix 
> > > this problem.
> > > Please help me to review it.
> > >   
> > >
> > >      
> > As per the patch, we would no more depend upon the check for built-in
> >    
> or
>  
>
> > non built-in items. I think this might affect the desired behavior.
> > Srini: what is your opinion here?
> >
> > Thanks,
> > Kaushal 
> >
> >
> >    
>
>
>